From: John Ogness <john.ogness@linutronix.de>
To: Zhu Yanjun <zyjzyj2000@gmail.com>
Cc: Zhu Yanjun <yanjun.zhu@linux.dev>,
Li Zhijian <lizhijian@fujitsu.com>,
linux-rdma@vger.kernel.org, "pmladek@suse.com" <pmladek@suse.com>,
"senozhatsky@chromium.org" <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
jgg@ziepe.ca, leon@kernel.org, linux-kernel@vger.kernel.org,
rpearsonhpe@gmail.com,
Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
Subject: Re: [PATCH v2 1/2] RDMA/rxe: Improve newline in printing messages
Date: Mon, 28 Aug 2023 12:57:43 +0206 [thread overview]
Message-ID: <87fs43cudc.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <CAD=hENcu4wKELCt61O+p-RtOpaHHoaAQhr7Ygt9pdr9Hc4s2Wg@mail.gmail.com>
On 2023-08-28, Zhu Yanjun <zyjzyj2000@gmail.com> wrote:
> Do you mean "a newline can help flushing messages out"?
> That is, in printk, the message will be buffered until it is full or
> it meets a newline?
Correct. A trailing newline is needed for the record to become
"finalized". Only finalized records are pushed out to consoles.
If there is no trailing newline, the message will be buffered until
printk is called using a message with a trailing newline.
There are some other reasons why it may be flushed. But for sure the
flushing will be delayed if there is no trailing newline.
John Ogness
next prev parent reply other threads:[~2023-08-28 10:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 6:11 [PATCH v2 1/2] RDMA/rxe: Improve newline in printing messages Li Zhijian
2023-08-23 6:11 ` [PATCH v2 2/2] RDMA/rxe: Call rxe_set_mtu after rxe_register_device Li Zhijian
2023-09-16 2:28 ` Zhu Yanjun
2023-08-23 7:07 ` [PATCH v2 1/2] RDMA/rxe: Improve newline in printing messages Daisuke Matsuda (Fujitsu)
2023-08-23 7:16 ` Zhijian Li (Fujitsu)
2023-08-23 7:25 ` Daisuke Matsuda (Fujitsu)
2023-08-23 7:36 ` Zhijian Li (Fujitsu)
2023-08-23 7:43 ` Zhu Yanjun
2023-08-28 8:56 ` John Ogness
2023-08-28 10:15 ` Zhu Yanjun
2023-08-28 10:51 ` John Ogness [this message]
2023-08-28 12:15 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs43cudc.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=matsuda-daisuke@fujitsu.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=rpearsonhpe@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox