From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6693F1779B8 for ; Fri, 4 Apr 2025 09:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743760415; cv=none; b=XOvsX5+5oZCCtA/ewM3tjMCqFZGkgZzOlT7ZTj+T3Ojd6rwwvVsHatFesypWab7cuI7wbC7ezJk52CSJpBWNP9viS5Rp/KSzVWKFmrEJHVV+hY22KPZ4ymjFGIsDeWw4ov9+fWqOuP8MEBWoRv+J1Dbju9eoy2/tGV5HvnFk9Dg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743760415; c=relaxed/simple; bh=idfTmf4ycwMLOUECqnSVWwqShx0XOcb7QDlksx8VU6Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=OMylR2NXm+XgRliejKI8w0zvwP06sNjJ3UqIOI2m1o3oSDMtyVtujSylua3u2Hsq0f5SuAC06VVTN538ho1YZYeKspVCczGqKqpwfjw9O2Slx+6zIXAh+jW2VzwgObAjHqcH2BvYeEugkaFCJmZ/qAgE37iYbDIF1QsB51OKPJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Q0iEAhm8; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q0iEAhm8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743760412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LVGQCiVyZHkGXnn98AxsiJpRPwaHkCR4E26XV5UfwnI=; b=Q0iEAhm8NcYPXa/hg3KAp1puMVD5XjkeCBlSYGVBmD/oWYszRaDFxWCVV5JuWAfYbnDBF2 CfeeW/BR6DP6RYCDxuP2qWvUzs35YukhH5MYfk2zaXIlV4Ik+FOAThnreTvTAeCrNqPqG9 rFLqYc9H8etuSx+73XCdrO6Qq1dVjF4= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-Gj6T4VOyPF-d9arNCF1DyQ-1; Fri, 04 Apr 2025 05:53:30 -0400 X-MC-Unique: Gj6T4VOyPF-d9arNCF1DyQ-1 X-Mimecast-MFC-AGG-ID: Gj6T4VOyPF-d9arNCF1DyQ_1743760409 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-ac3df3f1193so146901366b.2 for ; Fri, 04 Apr 2025 02:53:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743760409; x=1744365209; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LVGQCiVyZHkGXnn98AxsiJpRPwaHkCR4E26XV5UfwnI=; b=fQHoBedZKFHrFUzrQsIahWwFoc3EFPXb4ShNgWdQZ+sS+/w2BFLSaUtquLJxxcYfKn GHlwvWlHvI9CQ2KoWlF3lblmv6xm8YsTioTplzhoeqbAvd/g928TMm+wrVzHCBuQMnvq X79NqYTstGMynhynErEzjyW086emk8NPvpfekthHrLiSOur0yGqZhiBWpXFpfFZt8at5 6IszqpBiYwyGwKlvuJFkYdKfwwzAqwMnXQxmr9LwiofmGHQE4kwhuplhm/42KApdu+WG DJzvMAnFDPzs3hqyV1pfDhgs5PfGJTCNGqX/d/9mX5kMc2gbpo8+d+YbA44gxzbu+0rF z9mg== X-Forwarded-Encrypted: i=1; AJvYcCVPE1o9a6hYzaxrtzkEW/tEeICuNSTXH182AL0MwlcmO4bSMBvUHaMe1rYnqyctvtYW0lSXReVQGzsr@vger.kernel.org X-Gm-Message-State: AOJu0Yy4CyX08QdPDDohERos2sXtwgqIgYK2KXEAEZ+7KrKjh4k9MOS4 WlMAG1KLQiCXzmi7Xd/kYx9gMImztdSvYKnhN0DhJYXP2E8ExOTeUfiaoMvSW6pC/F+K9HzhXMX C9VwSWF34qqiDJ/TyesJgWyDF2nIQmjJWF7E26sza9kE9kahfooMFwuCJ4Xc= X-Gm-Gg: ASbGnct6Y+3n660Aay2JbU4XMWfa/sJ2vCU7hWrpdwNpaaegUOXTcd7WnA0Ypx5aBXH ylwH0hUTC1OxoiCW8+DIs4cSHQIVKHljIEa4IhXS1puecT+DiwONOV1UCuF/5e/pCxtFkSfgsDe dNCHwOZipbNVJIZF75WuYbZId5bj55Gw9ETIIqi9JVZOHQp7tnnNgZ79b0YPrAiMn5mtmX5/x9a qVoqIefZYN8/s0/CgqjzUJnt2BRFWFzenQniAm1b++LZZaerqjmrTRobXPHukQA3fRGOE1+xFeW gIlzdKz1GMR5eNg54Hg2AHmISqKBckVlBAt94ffD X-Received: by 2002:a17:907:2da1:b0:abf:6db5:c9a9 with SMTP id a640c23a62f3a-ac7d6e07489mr142802666b.39.1743760409207; Fri, 04 Apr 2025 02:53:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1XTUa7Ek2WhdvH5WJS2AIV0agLDZZ/Z+JEVHEXzqYzD3Mqsj3alR3nhhtT2rdlTKU/t/FhQ== X-Received: by 2002:a17:907:2da1:b0:abf:6db5:c9a9 with SMTP id a640c23a62f3a-ac7d6e07489mr142800266b.39.1743760408780; Fri, 04 Apr 2025 02:53:28 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac7c0185726sm224898366b.137.2025.04.04.02.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Apr 2025 02:53:28 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id C858818FD70F; Fri, 04 Apr 2025 11:53:26 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jakub Kicinski Cc: "David S. Miller" , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, Qiuling Ren , Yuying Ma Subject: Re: [PATCH net-next v6 2/2] page_pool: Track DMA-mapped pages and unmap them when destroying the pool In-Reply-To: <20250403153129.013a7bdd@kernel.org> References: <20250401-page-pool-track-dma-v6-0-8b83474870d4@redhat.com> <20250401-page-pool-track-dma-v6-2-8b83474870d4@redhat.com> <20250403153129.013a7bdd@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 04 Apr 2025 11:53:26 +0200 Message-ID: <87tt74l0bt.fsf@toke.dk> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jakub Kicinski writes: > On Tue, 01 Apr 2025 11:27:19 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> + if (err) { >> + WARN_ONCE(1, "couldn't track DMA mapping, please report to netdev@"); >> goto unmap_failed; > > FWIW I second Pavel's concern about the warning being too drastic. > I have the feeling Meta's fleet will hit this. > How about WARN_ONCE(err !=3D -ENOMEM, ... ? I presume you care mostly > about the array filling up so -EBUSY Ah yes, that's a good solution, will do! >> + } >>=20=20 >> + if (page_pool_set_dma_addr_netmem(netmem, dma)) { >> + WARN_ONCE(1, "unexpected DMA address, please report to netdev@"); >> + goto unmap_failed; >> + } > > I think this is ever so slightly leaking the id, if it ever happens? Good catch! Will swap the order of the operations. -Toke