From: Kalle Valo <kvalo@codeaurora.org>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: "Ronak Doshi" <doshir@vmware.com>,
"Sergey Matyukevich" <smatyukevich@quantenna.com>,
"VMware, Inc." <pv-drivers@vmware.com>,
"Chris Snook" <chris.snook@gmail.com>,
"Chi-Hsien Lin" <chi-hsien.lin@cypress.com>,
"Arend van Spriel" <arend.vanspriel@broadcom.com>,
linux-kernel@vger.kernel.org,
"Vishal Kulkarni" <vishal@chelsio.com>,
"Samuel Chessman" <chessman@tux.org>,
"Rafał Miłecki" <rafal@milecki.pl>,
netdev@vger.kernel.org, "Avinash Patil" <avinashp@quantenna.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Manish Chopra" <manishc@marvell.com>,
linux-rdma@vger.kernel.org, "Will Deacon" <will@kernel.org>,
"Guo-Fu Tseng" <cooldavid@cooldavid.org>,
"Rahul Verma" <rahulv@marvell.com>,
ath10k@lists.infradead.org, brcm80211-dev-list@cypress.com,
"Saeed Mahameed" <saeedm@mellanox.com>,
linux-hippi@sunsite.dk, "Franky Lin" <franky.lin@broadcom.com>,
"Yang Wei" <yang.wei9@zte.com.cn>
Subject: Re: [PATCH v2 16/27] net: remove unneeded memset
Date: Fri, 28 Jun 2019 08:00:54 +0300 [thread overview]
Message-ID: <87v9wqqp6h.fsf@codeaurora.org> (raw)
In-Reply-To: <20190628024843.15635-1-huangfq.daxian@gmail.com> (Fuqian Huang's message of "Fri, 28 Jun 2019 10:48:31 +0800")
Fuqian Huang <huangfq.daxian@gmail.com> writes:
> The memset with 0 after zeroing allocator is unneeded.
>
> pci_alloc_persistent calls dma_alloc_coherent directly.
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dma_alloc_coherent has already zeroed the memory.
> So the memset after these functions is unneeded.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> drivers/net/ethernet/atheros/atlx/atl1.c | 2 --
> drivers/net/ethernet/atheros/atlx/atl2.c | 1 -
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 --
> drivers/net/ethernet/chelsio/cxgb4/sched.c | 1 -
> drivers/net/ethernet/freescale/fec_main.c | 2 --
> drivers/net/ethernet/jme.c | 5 -----
> drivers/net/ethernet/marvell/skge.c | 2 --
> drivers/net/ethernet/mellanox/mlx4/eq.c | 2 --
> drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 1 -
> drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 --
> drivers/net/ethernet/mellanox/mlxsw/pci.c | 1 -
> drivers/net/ethernet/neterion/s2io.c | 1 -
> drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c | 3 ---
> drivers/net/ethernet/ti/tlan.c | 1 -
> drivers/net/hippi/rrunner.c | 2 --
> drivers/net/vmxnet3/vmxnet3_drv.c | 1 -
> drivers/net/wireless/ath/ath10k/ce.c | 5 -----
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 --
> drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c | 2 --
> drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c | 2 --
For the wireless part:
Acked-by: Kalle Valo <kvalo@codeaurora.org>
I assume Dave will take this.
--
Kalle Valo
prev parent reply other threads:[~2019-06-28 5:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 2:48 [PATCH v2 16/27] net: remove unneeded memset Fuqian Huang
2019-06-28 5:00 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9wqqp6h.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=ath10k@lists.infradead.org \
--cc=avinashp@quantenna.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chessman@tux.org \
--cc=chi-hsien.lin@cypress.com \
--cc=chris.snook@gmail.com \
--cc=cooldavid@cooldavid.org \
--cc=doshir@vmware.com \
--cc=franky.lin@broadcom.com \
--cc=huangfq.daxian@gmail.com \
--cc=linux-hippi@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=rafal@milecki.pl \
--cc=rahulv@marvell.com \
--cc=saeedm@mellanox.com \
--cc=smatyukevich@quantenna.com \
--cc=tglx@linutronix.de \
--cc=vishal@chelsio.com \
--cc=will@kernel.org \
--cc=yang.wei9@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox