Re: modprobe rdma_rxe failed when ipv6 disabled

[Yi Zhang <yi.zhang@redhat.com>]

Tested-by: Yi Zhang <yi.zhang@redhat.com>

# modprobe rdma_rxe
# dmesg
[  598.134022] rdma_rxe: IPv6 is disabled by ipv6.disable=1 in cmdline
[  598.134026] rdma_rxe: loaded




On 2/28/21 5:23 PM, Leon Romanovsky wrote:
> On Sat, Feb 27, 2021 at 11:32:35PM +0800, Zhu Yanjun wrote:
>>  From 9dcdd09f3ca3cf222b563866acd91d18bc4b93d4 Mon Sep 17 00:00:00 2001
>> From: Zhu Yanjun <zyjzyj2000@gmail.com>
>> Date: Sat, 27 Feb 2021 23:01:15 +0000
>> Subject: [PATCH 1/1] RDMA/rxe: Disable ipv6 features when ipv6.disable set in
>>   cmdline
>>
>> When ipv6.disable=1 is set in cmdline, ipv6 is actually disabled
>> in the stack. As such, the operations of ipv6 in RXE will fail.
>> So ipv6 features in RXE should also be disabled in RXE.
>>
>> Reported-by: Yi Zhang <yi.zhang@redhat.com>
>> Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>
>> ---
>>   drivers/infiniband/sw/rxe/rxe_net.c | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c
>> b/drivers/infiniband/sw/rxe/rxe_net.c
>> index 0701bd1ffd1a..6ef092cb575e 100644
>> --- a/drivers/infiniband/sw/rxe/rxe_net.c
>> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
>> @@ -72,6 +72,11 @@ static struct dst_entry *rxe_find_route6(struct
>> net_device *ndev,
>>          struct dst_entry *ndst;
>>          struct flowi6 fl6 = { { 0 } };
>>
>> +       if (!ipv6_mod_enabled()) {
>> +               pr_info("IPv6 is disabled by ipv6.disable=1 in cmdline");
>> +               return NULL;
>> +       }
>> +
>
> Except the info message, the change looks valid.
>
> pr_info("IPv6 is disabled by ipv6.disable=1 in cmdline");
> ->
> pr_info("IPv6 is disabled");
>
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
>