From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ghazale Hosseinabadi Subject: Re: [PATCH rdma-core] libibumad/umad.c: In get_port, ignore sysfs rate file errors Date: Tue, 31 Oct 2017 11:09:12 -0700 Message-ID: <89d48a68-66b6-e697-7d6f-c5c856cd2c83@oracle.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hal Rosenstock , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 10/31/2017 05:14 AM, Hal Rosenstock wrote: > This can cause ibpanic in ibstat when width is not set properly > as can occur when QSPF is not plugged into port. > > ibpanic: [7851] main: stat of IB device 'mlx5_1' failed: Invalid argument > > It's caused by kernel sysfs.c:show_rate returning -EINVAL > and that error being treated as failure in umad.c:get_port. > With this change, Rate is displayed as 0 with ibstat for this scenario. > > Signed-off-by: Hal Rosenstock Tested by: Ghazale Hosseinabadi > --- > libibumad/umad.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libibumad/umad.c b/libibumad/umad.c > index 535256e..dcb2c68 100644 > --- a/libibumad/umad.c > +++ b/libibumad/umad.c > @@ -150,8 +150,7 @@ static int get_port(const char *ca_name, const char *dir, int portnum, umad_port > goto clean; > if (sys_read_uint(port_dir, SYS_PORT_PHY_STATE, &port->phys_state) < 0) > goto clean; > - if (sys_read_uint(port_dir, SYS_PORT_RATE, &port->rate) < 0) > - goto clean; > + sys_read_uint(port_dir, SYS_PORT_RATE, &port->rate); > if (sys_read_uint(port_dir, SYS_PORT_CAPMASK, &capmask) < 0) > goto clean; > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html