From: Paolo Abeni <pabeni@redhat.com>
To: "D. Wythe" <alibuda@linux.alibaba.com>,
kgraul@linux.ibm.com, wenjia@linux.ibm.com, jaka@linux.ibm.com,
wintera@linux.ibm.com, guwen@linux.alibaba.com
Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org,
tonylu@linux.alibaba.com, edumazet@google.com
Subject: Re: [PATCH net-next] net/smc: add sysctl for smc_limit_hs
Date: Tue, 10 Sep 2024 12:10:32 +0200 [thread overview]
Message-ID: <8a1684ca-755b-4612-afe1-41340b46f2fe@redhat.com> (raw)
In-Reply-To: <1725590135-5631-1-git-send-email-alibuda@linux.alibaba.com>
On 9/6/24 04:35, D. Wythe wrote:
> From: "D. Wythe" <alibuda@linux.alibaba.com>
>
> In commit 48b6190a0042 ("net/smc: Limit SMC visits when handshake workqueue congested"),
> we introduce a mechanism to put constraint on SMC connections visit
> according to the pressure of SMC handshake process.
>
> At that time, we believed that controlling the feature through netlink
> was sufficient. However, most people have realized now that netlink is
> not convenient in container scenarios, and sysctl is a more suitable
> approach.
Not blocking this patch, but could you please describe why/how NL is
less convenient? is possibly just a matter of lack of command line tool
to operate on NL? yaml to the rescue ;)
Cheers,
Paolo
next prev parent reply other threads:[~2024-09-10 10:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 2:35 [PATCH net-next] net/smc: add sysctl for smc_limit_hs D. Wythe
2024-09-10 10:10 ` Paolo Abeni [this message]
2024-09-11 2:53 ` D. Wythe
2024-09-10 10:20 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2024-08-15 13:03 D. Wythe
2024-08-15 13:14 ` Wen Gu
2024-08-16 2:06 ` D. Wythe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a1684ca-755b-4612-afe1-41340b46f2fe@redhat.com \
--to=pabeni@redhat.com \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=jaka@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox