[PATCH] RDMA/efa: Remove possible negative shift

[PATCH] RDMA/efa: Remove possible negative shift

[Michael Margolin]

The page size used for device might in some cases be smaller than
PAGE_SIZE what results in a negative shift when calculating the number
of host pages in PAGE_SIZE for a debug log. Remove the debug line
together with the calculation.

Reviewed-by: Tom Sela <tomsela@amazon.com>
Reviewed-by: Yonatan Nachum <ynachum@amazon.com>
Signed-off-by: Michael Margolin <mrgolin@amazon.com>
---
 drivers/infiniband/hw/efa/efa_verbs.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/infiniband/hw/efa/efa_verbs.c b/drivers/infiniband/hw/efa/efa_verbs.c
index 22d3e25c3b9d..755bba8d58bb 100644
--- a/drivers/infiniband/hw/efa/efa_verbs.c
+++ b/drivers/infiniband/hw/efa/efa_verbs.c
@@ -1320,13 +1320,9 @@ static int umem_to_page_list(struct efa_dev *dev,
 			     u32 hp_cnt,
 			     u8 hp_shift)
 {
-	u32 pages_in_hp = BIT(hp_shift - PAGE_SHIFT);
 	struct ib_block_iter biter;
 	unsigned int hp_idx = 0;
 
-	ibdev_dbg(&dev->ibdev, "hp_cnt[%u], pages_in_hp[%u]\n",
-		  hp_cnt, pages_in_hp);
-
 	rdma_umem_for_each_dma_block(umem, &biter, BIT(hp_shift))
 		page_list[hp_idx++] = rdma_block_iter_dma_address(&biter);
 
-- 
2.47.3

Re: [PATCH] RDMA/efa: Remove possible negative shift

[Gal Pressman]

On 10/12/2025 19:36, Michael Margolin wrote:
> The page size used for device might in some cases be smaller than
> PAGE_SIZE what results in a negative shift when calculating the number
> of host pages in PAGE_SIZE for a debug log. Remove the debug line
> together with the calculation.
> 
> Reviewed-by: Tom Sela <tomsela@amazon.com>
> Reviewed-by: Yonatan Nachum <ynachum@amazon.com>
> Signed-off-by: Michael Margolin <mrgolin@amazon.com>

Reviewed-by: Gal Pressman <gal.pressman@linux.dev>

I don't know if you target this to -rc or -next, but this probably
deserves a Fixes tag.

Re: [PATCH] RDMA/efa: Remove possible negative shift

[Jason Gunthorpe]

On Wed, Dec 10, 2025 at 05:36:56PM +0000, Michael Margolin wrote:
> The page size used for device might in some cases be smaller than
> PAGE_SIZE what results in a negative shift when calculating the number
> of host pages in PAGE_SIZE for a debug log. Remove the debug line
> together with the calculation.
> 
> Reviewed-by: Tom Sela <tomsela@amazon.com>
> Reviewed-by: Yonatan Nachum <ynachum@amazon.com>
> Signed-off-by: Michael Margolin <mrgolin@amazon.com>
> Reviewed-by: Gal Pressman <gal.pressman@linux.dev>
> ---
>  drivers/infiniband/hw/efa/efa_verbs.c | 4 ----
>  1 file changed, 4 deletions(-)

I added

Fixes: 40909f664d27 ("RDMA/efa: Add EFA verbs implementation")

Jason