Re: [PATCH bpf-next 4/4] bpf/selftests: add simple selftest for bpf_smc_ops

Zhu Yanjun
2024-11-26T08:30:01Z

在 2024/11/26 0:32, Martin KaFai Lau 写道:
> On 11/25/24 2:52 AM, Zhu Yanjun wrote:
>>>> # ./test_progs -t smc
>>>> #27/1    bpf_smc/load:OK
>>>> #27      bpf_smc:OK
>>>> Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
>>>>
>>>> The above command is based on several kernel modules. After these
>>>> dependent kernel modules are loaded, then can run the above command
>>>> successfully.
>
>>>
>>> This is indeed a problem, a better way may be to create a separate
>>> testing directory for SMC, and we are trying to do this.
>>
>> Got it. In the latest patch series, if a test program in sample/bpf
>> can verify this bpf feature, it is better than a selftest program in
>> the directory tools/ testing/selftests/bpf.
>>
>> I delved into this selftest tool. It seems that this selftest tool
>> only makes the basic checks. A test program in sample/bpf can do more.
>
> sample(s)/bpf? No new test should be added to samples/bpf which is
> obsolete. The bpf CI only runs tests under selftests/bpf.

Thanks for letting me know this, Martin.

In the past, with samples/bpf, we can know a lot of details of bpf
samples. But in the selftests/bpf, it seems that only load method can be
found. For example, in this smc bpf selftests commit, we can not find
how to change parameters in smc. In the past, this method about how to
change parameters can be found in samples/bpf.

I am not sure whether this selftests/bpf is designed for this simple
tests or the detailed information can be found in other places.

Zhu Yanjun

>
> There is selftests/bpf/config to tell the bpf CI about what kconfig
> needs to turn on.
>