Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
To: Bob Pearson <rpearsonhpe@gmail.com>,
	Yanjun Zhu <yanjun.zhu@linux.dev>, Jason Gunthorpe <jgg@ziepe.ca>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH for-next] RDMA/rxe: check rxe_pd before rxe_put in rxe_mr_cleanup()
Date: Sat, 16 Jul 2022 08:05:30 +0000	[thread overview]
Message-ID: <8df53e84-6743-5d48-1550-d214585acc29@fujitsu.com> (raw)
In-Reply-To: <545a4df9-4c5d-a74c-5359-2a4f484a8829@gmail.com>

Bob

on 7/16/2022 2:28 AM, Bob Pearson wrote:
> Li,
>
> I just sent in an alternative patch that fixes up the error paths.

thanks for your patch, i will take a look later.


> We not only have a problem with PD but also umem.

In my understanding, although the umem is also not set in the same case, 
it's safe to pass NULL to ib_umem_release()  currently.

Thanks


> I moved the setting
> of PD up so it will always be set before cleanup gets called and also
> checks if umem is set before freeing it. Please take a look at it.

      reply	other threads:[~2022-07-16  8:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06  9:21 [PATCH for-next] RDMA/rxe: check rxe_pd before rxe_put in rxe_mr_cleanup() lizhijian
2022-07-12  1:06 ` lizhijian
2022-07-14 16:13 ` Bob Pearson
2022-07-15  3:37   ` lizhijian
2022-07-15 18:28     ` Bob Pearson
2022-07-16  8:05       ` lizhijian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8df53e84-6743-5d48-1550-d214585acc29@fujitsu.com \
    --to=lizhijian@fujitsu.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rpearsonhpe@gmail.com \
    --cc=yanjun.zhu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox