From: David Ahern <dsahern@gmail.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Michael Guralnik <michaelgur@nvidia.com>,
jgg@nvidia.com, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, Chiara Meiohas <cmeiohas@nvidia.com>
Subject: Re: [RFC iproute2-next 2/4] rdma: Add support for rdma monitor
Date: Mon, 2 Sep 2024 10:55:15 -0600 [thread overview]
Message-ID: <8e652f69-78d0-40f0-a712-60ef8733cf29@gmail.com> (raw)
In-Reply-To: <20240902075426.GD4026@unreal>
On 9/2/24 1:54 AM, Leon Romanovsky wrote:
> On Sun, Sep 01, 2024 at 08:22:50PM -0600, David Ahern wrote:
>> On 8/31/24 6:54 PM, Michael Guralnik wrote:
>>> $ echo 4 > /sys/class/net/eth2/device/sriov_numvfs
>>> [NETDEV_ATTACH] dev 6 port 2 netdev 7
>>> [NETDEV_ATTACH] dev 6 port 3 netdev 8
>>> [NETDEV_ATTACH] dev 6 port 4 netdev 9
>>> [NETDEV_ATTACH] dev 6 port 5 netdev 10
>>> [REGISTER] dev 7
>>> [NETDEV_ATTACH] dev 7 port 1 netdev 11
>>> [REGISTER] dev 8
>>> [NETDEV_ATTACH] dev 8 port 1 netdev 12
>>> [REGISTER] dev 9
>>> [NETDEV_ATTACH] dev 9 port 1 netdev 13
>>> [REGISTER] dev 10
>>> [NETDEV_ATTACH] dev 10 port 1 netdev 14
>>>
>>
>> at a minimum the netdev output can be device names not indices; I would
>> expect the same for IB devices (I think that is the `dev N` in the
>> output) though infrastructure might be needed in iproute2.
>
> I understand the request and it is a good one for the users of the tool.
>
> However, we will need to remember that "real" users of this monitoring
> UAPI (from kernel side) are the orchestration tools and they won't care
> about the names, but about the IDs, which won't be used in rdmatool.
>
That's a big assumption.
It is trivial to convert indices to names, so this can be readable for both.
next prev parent reply other threads:[~2024-09-02 16:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 0:54 [RFC iproute2-next 0/4] Add RDMA monitor support Michael Guralnik
2024-09-01 0:54 ` [RFC iproute2-next 1/4] rdma: Update uapi header Michael Guralnik
2024-09-01 0:54 ` [RFC iproute2-next 2/4] rdma: Add support for rdma monitor Michael Guralnik
2024-09-01 15:44 ` Stephen Hemminger
2024-09-02 2:22 ` David Ahern
2024-09-02 7:54 ` Leon Romanovsky
2024-09-02 16:55 ` David Ahern [this message]
2024-09-02 18:12 ` Leon Romanovsky
2024-09-04 15:54 ` Jason Gunthorpe
2024-09-01 0:54 ` [RFC iproute2-next 3/4] rdma: Expose whether RDMA monitoring is supported Michael Guralnik
2024-09-01 0:54 ` [RFC iproute2-next 4/4] rdma: Fix typo in rdma-link man page Michael Guralnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e652f69-78d0-40f0-a712-60ef8733cf29@gmail.com \
--to=dsahern@gmail.com \
--cc=cmeiohas@nvidia.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michaelgur@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox