From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Ming Lei <ming.lei@redhat.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, "Ewan D. Milne" <emilne@redhat.com>,
Laurence Oberman <loberman@redhat.com>,
linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] RDMA/srp: don't set a max_segment_size when virt_boundary_mask is set
Date: Mon, 23 Jun 2025 08:31:37 -0700 [thread overview]
Message-ID: <8eae59ce-1d46-4c9c-af6f-0f6bb39a8286@acm.org> (raw)
In-Reply-To: <20250623080326.48714-2-hch@lst.de>
On 6/23/25 1:02 AM, Christoph Hellwig wrote:
> virt_boundary_mask implies an unlimited max_segment_size. Setting both
> can lead to data corruption, and we're going to check for this in the
> SCSI midlayer soon.
Please make this patch description more detailed and mention that
__blk_rq_map_sg() may split sg-lists such that the virt_boundary_mask is
not respected if max_segment_size != UINT_MAX.
Thanks,
Bart.
next prev parent reply other threads:[~2025-06-23 15:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 8:02 fix virt_boundary_mask handling in SCSI Christoph Hellwig
2025-06-23 8:02 ` [PATCH 1/2] RDMA/srp: don't set a max_segment_size when virt_boundary_mask is set Christoph Hellwig
2025-06-23 15:31 ` Bart Van Assche [this message]
2025-06-24 5:57 ` Hannes Reinecke
2025-06-23 8:02 ` [PATCH 2/2] scsi: enforce unlimited " Christoph Hellwig
2025-06-23 8:37 ` John Garry
2025-06-23 13:35 ` Christoph Hellwig
2025-06-23 14:03 ` John Garry
2025-06-23 14:05 ` Christoph Hellwig
2025-06-23 9:50 ` Ming Lei
2025-06-24 5:57 ` Hannes Reinecke
2025-06-24 14:21 ` fix virt_boundary_mask handling in SCSI Laurence Oberman
2025-06-24 16:11 ` Laurence Oberman
2025-06-24 16:13 ` Laurence Oberman
-- strict thread matches above, loose matches on Subject: below --
2025-06-24 12:52 fix virt_boundary_mask handling in SCSI v2 Christoph Hellwig
2025-06-24 12:52 ` [PATCH 1/2] RDMA/srp: don't set a max_segment_size when virt_boundary_mask is set Christoph Hellwig
2025-06-24 13:25 ` John Garry
2025-06-24 15:54 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eae59ce-1d46-4c9c-af6f-0f6bb39a8286@acm.org \
--to=bvanassche@acm.org \
--cc=emilne@redhat.com \
--cc=haiyangz@microsoft.com \
--cc=hch@lst.de \
--cc=kys@microsoft.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).