Re: [PATCH for-next 0/5] Add scatter FCS support

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2831 bytes --]

On 04/17/2016 10:19 AM, Matan Barak wrote:
> Hi Doug,
> 
> Frame Check Sequence (FCS) is an error detecting code that terminates
> an Ethernet frame. When using Raw Ethernet, users sometimes want
> to validate the FCS themselves, and therefore it should be scattered
> to the receive buffers.
> 
> This series adds the above support.
> 
> The user can control scattering the FCS using Queue-Pair(QP) creation
> flag called IB_QP_CREATE_SCATTER_FCS.
> 
> Also, to report this new device capability, we had to add a new
> device capability flags in the uverbs response called
> device_cap_flags_ex, since all the current device_cap_flags are
> occupied.
> 
> device_cap_flags_ex 0-31 bits are identical to the legacy
> device_cap_flags, and the upper 32 bits (32-63 bits) report new
> extended device capabilities.
> 
> Devices that support scattering the FCS should report it in
> device_cap_flags_ex using IB_DEVICE_RAW_SCATTER_FCS.
> 
> This patch depends on the mlx5 core shared code that was sent to both
> IB and net trees and was already accepted by Dave Miller:
> net/mlx5: Update mlx5_ifc hardware features
> net/mlx5: Fix mlx5 ifc cmd_hca_cap bad offsets
> 
> Moreover, this patch conflicts with the LSO series (that will be
> sent soon). The resolution of this conflict is available in
> Mellanox's tree.
> 
> Thanks,
> Majd and Matan
> 
> Majd Dibbiny (5):
>   IB/core: Add extended device capability flags
>   IB/core: Add Raw Scatter FCS device capability
>   IB/core: Add Scatter FCS create flag
>   IB/mlx5: Add Scatter FCS support for Raw Packet QP
>   IB/mlx5: Report Scatter FCS device capability when supported
> 
>  drivers/infiniband/core/uverbs_cmd.c |  8 +++++++-
>  drivers/infiniband/hw/mlx5/main.c    |  4 ++++
>  drivers/infiniband/hw/mlx5/mlx5_ib.h |  1 +
>  drivers/infiniband/hw/mlx5/qp.c      | 20 +++++++++++++++++++-
>  include/rdma/ib_verbs.h              |  2 ++
>  include/uapi/rdma/ib_user_verbs.h    |  1 +
>  6 files changed, 34 insertions(+), 2 deletions(-)
> 

This patchset is a uAPI extending patchset.  Recently, there has been
talk of requiring a higher level of review and acknowledgment from
various vendors for such patches.  However, in this case, it extends the
QP creation code, which is already an extended function, and it extends
it in a manner consistent with the original extension mechanism.  The
only use visible change is a new bit in a bitmap with plenty of space
free at the moment, and the resulting WC SGE entries will be extended.
The overall patches themselves look fine, the extension was done
appropriately, and this isn't a newly extended API, so I'm OK taking
these as they are.  Applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]