From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [PATCH] RDMA/odp: Fix missed unlock in non-blocking invalidate_start Date: Mon, 17 Jun 2019 15:56:34 -0400 Message-ID: <92ef28dedfbe5adf7928caceeaa79b452492f44d.camel@redhat.com> References: <20190611160951.23135-1-jgg@ziepe.ca> <20190612161536.GS6369@mtr-leonro.mtl.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-ZWPd+e+sfldX6aOXW9Rd" Return-path: In-Reply-To: <20190612161536.GS6369@mtr-leonro.mtl.com> Sender: stable-owner@vger.kernel.org To: Leon Romanovsky , Jason Gunthorpe Cc: linux-rdma@vger.kernel.org, Moni Shoua , Jason Gunthorpe , stable@vger.kernel.org List-Id: linux-rdma@vger.kernel.org --=-ZWPd+e+sfldX6aOXW9Rd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2019-06-12 at 19:15 +0300, Leon Romanovsky wrote: > On Tue, Jun 11, 2019 at 01:09:51PM -0300, Jason Gunthorpe wrote: > > From: Jason Gunthorpe > >=20 > > If invalidate_start returns with EAGAIN then the umem_rwsem needs > > to be > > unlocked as no invalidate_end will be called. > >=20 > > Cc: > > Fixes: ca748c39ea3f ("RDMA/umem: Get rid of per_mm- > > >notifier_count") > > Signed-off-by: Jason Gunthorpe > > --- > > drivers/infiniband/core/umem_odp.c | 14 +++++++++----- > > 1 file changed, 9 insertions(+), 5 deletions(-) > >=20 >=20 > Thanks, > Reviewed-by: Leon Romanovsky Thanks, applied to for-next. --=20 Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint =3D AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD --=-ZWPd+e+sfldX6aOXW9Rd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEErmsb2hIrI7QmWxJ0uCajMw5XL90FAl0H8HIACgkQuCajMw5X L91AnxAAgivoNirOgguwm5USGyeORAmKQo2bF3OadlT7XFwv1DEj8Vp0Cx27u0Hb oxzMn0V0HJ4CH142yS2bX8N7dhbzXmWqUs7/9n/yTufXHQOy3FB8l3Iu6MirmvCL iromXBKfVaFltxCXgpfHugk+76RRQgZevbjg3+NUfYqGVBp/98WKMdzJVo9oMmzO p+MrWpYR5/1xnm1XFdfmpGxrubZzhX/jNcgmlESD5BWEcqAIP+WFk11x4JthuH7J 9uzgSbToQpiCd+qqoVael3yMbZBI5/zM0D5AdIfW6N8HWEpjH4y9HyN9r4xEj1ga cOAHYUfUCulzGkWrwq3Z+LvDzCirshsAmC+Zltmk3chSg//cyoHvj09XJvIVgK3P MMIJweBePpyrQ3uWW2o6SE5/uD3L/uHflyw5iHhFjXSrETNJzowJccE+zA6mEP0M k5k7TpZx/lnW2gvhLDyADydDhbbXORNTt738oK1G4pujKt3+M9kYLALhbgfqjlXC vSiBBDwZm0lJAxp+nCXtUBS3ZgsVmIrS1wyj59z24Txaqj8NGyJ3bIuAAOuiZ650 Pn+8uZzKjU/TQ/1iGtt0hKIOPSPZOQBJZPN634F6tBntrsgvpQfGhuuGfJiUe8L9 FiF1818NEdXftBDQBj7u+CmESbI2dWVHJNynO87TwY68sgNvl0I= =AFTM -----END PGP SIGNATURE----- --=-ZWPd+e+sfldX6aOXW9Rd--