From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD12AC433E4 for ; Tue, 28 Jul 2020 15:46:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D2772065E for ; Tue, 28 Jul 2020 15:46:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e3lKUWxn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730884AbgG1Pqm (ORCPT ); Tue, 28 Jul 2020 11:46:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730856AbgG1Pql (ORCPT ); Tue, 28 Jul 2020 11:46:41 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91120C061794 for ; Tue, 28 Jul 2020 08:46:41 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id t1so911775plq.0 for ; Tue, 28 Jul 2020 08:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=6PAjvFEQeHNURmaTmSCrlg7uiBSXJp/gcccXe2ZA90s=; b=e3lKUWxn/O25oRmGpaXE3CUBkQ9r2DipfQb4Phdzm3au77cA07FgPC358lQ8ZB2u8A I04PX6FjvMClakkANvXymZLOHx/+0bezGaijRP6tMa69Lp+fT6HHbak+ZakQ3q9PQxYI O+ToXnxaMp6KXgzZVv/nALRvNurlQXeaQW8HmiBxjduoypW5j3DgnHH+XB9kbLixvSQF vnrR/kPOLXRbqIYbqmq+NiXrZrtRewStiuAa0Bw8IorVGO/G9ICeGyj0kGjE1u1Dp3gG oBj5smq0aU2ePGvUTGqDofunOI0UO5Lyu+RGdf8TgknhM/w+Yi/Cwv9Ut+BiMHYO/0HJ BVFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=6PAjvFEQeHNURmaTmSCrlg7uiBSXJp/gcccXe2ZA90s=; b=JQcAXPnN1kwLw0dAJqN0JsY5Fveo1nJBrrjZAcN6vokjTcos2YuTWRVY6QPNb/pwlS 69d80l12rMWNCc8jHGDKq7O7/yGG5yQXWZZNLco7S8E0JpMEUGMcwCtUKXDscHiDSCa8 6tYs5WMgTS8qJxZ4MQwyO/Jb5XkdSYV7pM+3zotC02fV5RS82xEJQk7wEbXeQs+Uumow exxHFRuL2JvJ1d8/HyVtmYN3xGPShsI+GoAzJ70trvZ0T/yVUu1Gj7/+6y4izZE2u5bl uRcOh/rLQyxAtxFQdHV8JOw6YKZz3JCWd+TT7MCVyFQTba8HP+XjYZD9mg7HH0p21atx 4qFg== X-Gm-Message-State: AOAM531FrYXPE6JiUjreH9d6zYsHaoTuJHQ3qaIGVOgIkkDV66Nbq821 rjVjFCoQPFipPeDF3ebOzds= X-Google-Smtp-Source: ABdhPJwNdg5AnGaPZXtJDeZJVyEro0cETCMRgN3vg/pLcG9om3zvLIh28X3ZLHOok+/6OO/U9rISWA== X-Received: by 2002:a17:90a:8904:: with SMTP id u4mr5365098pjn.87.1595951201126; Tue, 28 Jul 2020 08:46:41 -0700 (PDT) Received: from [10.75.201.17] ([118.201.220.138]) by smtp.gmail.com with ESMTPSA id l16sm18508598pff.167.2020.07.28.08.46.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jul 2020 08:46:40 -0700 (PDT) Subject: Re: FW: [PATCH for-next] RDMA/rxe: Remove pkey table To: Kamal Heib Cc: Jason Gunthorpe , Yanjun Zhu , linux-rdma@vger.kernel.org, Doug Ledford References: <20200723055723.GA828525@kheib-workstation> <7a6d602f-1adc-cc36-5a11-e0beb6e31cec@gmail.com> <20200723072546.GA835185@kheib-workstation> <81816c7d-9b14-98de-c6ee-0a6b4a43a060@gmail.com> <20200723131549.GM25301@ziepe.ca> <4796e70a-ca67-2d48-fdd8-e5593474d204@gmail.com> <20200728083557.GA73564@kheib-workstation> <9a6f21eb-a9c7-ed77-31b3-f9befa5a49b0@gmail.com> <20200728134442.GA29573@kheib-workstation> From: Zhu Yanjun Message-ID: <93160a8d-fca7-defc-b39e-e6e5a97ddb87@gmail.com> Date: Tue, 28 Jul 2020 23:46:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.0.1 MIME-Version: 1.0 In-Reply-To: <20200728134442.GA29573@kheib-workstation> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 7/28/2020 9:44 PM, Kamal Heib wrote: > On Tue, Jul 28, 2020 at 09:21:06PM +0800, Zhu Yanjun wrote: >> On 7/28/2020 4:35 PM, Kamal Heib wrote: >>> On Thu, Jul 23, 2020 at 11:15:00PM +0800, Zhu Yanjun wrote: >>>> On 7/23/2020 9:15 PM, Jason Gunthorpe wrote: >>>>> On Thu, Jul 23, 2020 at 09:08:39PM +0800, Zhu Yanjun wrote: >>>>>> On 7/23/2020 3:25 PM, Kamal Heib wrote: >>>>>>> On Thu, Jul 23, 2020 at 02:58:41PM +0800, Zhu Yanjun wrote: >>>>>>>> On 7/23/2020 1:57 PM, Kamal Heib wrote: >>>>>>>>> On Wed, Jul 22, 2020 at 10:09:04AM +0800, Zhu Yanjun wrote: >>>>>>>>>> On Tue, Jul 21, 2020 at 7:28 PM Yanjun Zhu wrote: >>>>>>>>>>> From: Kamal Heib >>>>>>>>>>> Sent: Tuesday, July 21, 2020 6:16 PM >>>>>>>>>>> To: linux-rdma@vger.kernel.org >>>>>>>>>>> Cc: Yanjun Zhu ; Doug Ledford ; Jason Gunthorpe ; Kamal Heib >>>>>>>>>>> Subject: [PATCH for-next] RDMA/rxe: Remove pkey table >>>>>>>>>>> >>>>>>>>>>> The RoCE spec require from RoCE devices to support only the defualt pkey, While the rxe driver maintain a 64 enties pkey table and use only the first entry. With that said remove the maintaing of the pkey table and used the default pkey when needed. >>>>>>>>>>> >>>>>>>>>> Hi Kamal >>>>>>>>>> >>>>>>>>>> After this patch is applied, do you make tests with SoftRoCE and mlx hardware? >>>>>>>>>> >>>>>>>>>> The SoftRoCE should work well with the mlx hardware. >>>>>>>>>> >>>>>>>>>> Zhu Yanjun >>>>>>>>>> >>>>>>>>> Hi Zhu, >>>>>>>>> >>>>>>>>> Yes, please see below: >>>>>>>>> >>>>>>>>> $ ibv_rc_pingpong -d mlx5_0 -g 11 >>>>>>>>> local address: LID 0x0000, QPN 0x0000e3, PSN 0x728a4f, GID ::ffff:172.31.40.121 >>>>>>>> Can you make tests with GSI QP? >>>>>>>> >>>>>>>> Zhu Yanjun >>>>>>>> >>>>>> Is this the GSI ? >>>>>> >>>>>> Please check GSI in "InfiniBandTM Architecture Specification Volume 1 >>>>>> Release 1.3" >>>>>> >>>>>> Then make tests with GSI again. >>>> The followings are also removed by this commit. Not sure if it is good. >>>> >>>> " >>>> >>>> C9-42: If the destination QP is QP1, the BTH:P_Key shall be compared to the >>>> set of P_Keys associated with the port on which the packet arrived. If the >>>> P_Key matches any of the keys associated with the port, it shall be >>>> considered valid. >>>> >>>> " >>>> >>> The above is correct for ports that configured to work in InfiniBand >>> mode, while in RoCEv2 mode only the default P_Key should be associated >>> with the port (Please see below from "ANNEX A17: ROCEV2 (IP ROUTABLE >>> ROCE)): >>> >>> """ >>> 17.7.1 LOADING THE P_KEY TABLE >>> >>> Compliance statement C17-7: on page 1193 describes requirements for >>> setting the P_Key table based on an assumption that the P_Key table is >>> set directly by a Subnet Manager. However, RoCEv2 ports do not support >>> InfiniBand Subnet Management. Therefore, compliance statement C17-7: >>> on page 1193 does not apply to RoCEv2 ports. >> " >> >> C17-7: An HCA shall require no OS involvement to set the P_Key table; >> >> the P_Key table shall be set directly by Subnet Manager MADs. >> >> " >> >> In SoftRoCE, what set the P_Key table? >> > No one is setting the P_Key table in SoftRoCE, and no subnet manager in > the RoCE fabric. > > Could you please tell me what is wrong with this patch? Please read the mail thread again. GSI QP number is 1. In your commits, the handle of qpn == 1 is removed. It seems that it conflicts with IB specification. Not sure if it is good. > > Thanks, > Kamal > >>> Methods for setting the P_Key table associated with a RoCEv2 port are >>> not defined in this specification, except for the requirements for a >>> default P_Key described elsewhere in this annex. >>> """ >>> >>> Thanks, >>> Kamal >>> >>> >>>>> rping uses RDMA CM which goes over the GSI >>>>> >>>>> Jason