From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86DD6317160 for ; Mon, 27 Apr 2026 14:38:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777300716; cv=none; b=bwPc2ffXzkF9SzkAdba8xNsqEhXACmveTc7yI8OPydaVSw87VozSPyLovrXiGHBxqYqav0+a6H4OBKWy/eUJohtO7X5X5GkfV5kHzH4FHN/yaTogVGSMqWnvn5jJT40AFi6w3vdWHIqM+PoKcxwnvAM2uYdHcbtmR1eycLXr0CY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777300716; c=relaxed/simple; bh=46XpfX6wkHAcy501fXHRyYSs+6aBGubG2ApXfZePM2o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U1vlc0u3JMe+N5GsjMhHGw2RFHZ61f3B6lYuk57l5q4jkit7R0O1HP4ihVRmfRerCShobmk1pDo9TKdvqhSshdU2UbLvEKtB/BfwKQ3chlv4KK4Nulh6CbfuId3yEAa5Bc4RoeYv1yT5E2fWvv4fZIAvmgGULWLKSVMX818p4EY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XEc+n+bl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XEc+n+bl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC4D9C19425; Mon, 27 Apr 2026 14:38:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777300716; bh=46XpfX6wkHAcy501fXHRyYSs+6aBGubG2ApXfZePM2o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XEc+n+blhoNyH0GDjc7bBAn0krFLEdsPPdaSIt3aKFBEPnwU3ri804+Acc2B+7PwN aifglQ20yw0WDP3+iS5H5CVBda9ktjL/FUJJMlsAy2/1eaZmUZTuTRe+7QKLNK4Xr3 Yd3MbTSNJR21MzJT1CmT7MeThbqTKLVCGW13r1s7uJL3OGFXYpWriJiBMYfHoAzMtx 09noZzZ1xkfzUOrPHhZob7IpT3U5lW5mcURLtapeUSIPoVRMGsK25Vu+LLMxS2fUju KC1yKizQD9JmfXtTHAbICBEYUSpTdYAIrmHFaaf2K/hyu9eKrgR9LIC9FISThdUs6v 0TYxO28dDMXFw== Message-ID: <9681c9e2-79a9-4d72-b1ad-229ba6d7aab7@kernel.org> Date: Mon, 27 Apr 2026 08:38:35 -0600 Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] RDMA/rxe: Fix null-ptr-deref in kernel_sock_shutdown(). Content-Language: en-US To: Zhu Yanjun , Kuniyuki Iwashima Cc: Zhu Yanjun , Jason Gunthorpe , Leon Romanovsky , Kuniyuki Iwashima , linux-rdma@vger.kernel.org, syzbot+d8f76778263ab65c2b21@syzkaller.appspotmail.com References: <20260425060436.2316620-1-kuniyu@google.com> <20260425060436.2316620-2-kuniyu@google.com> <030d3487-b5b9-4067-8b8c-89b4e8756e1a@linux.dev> <86499305-4522-4a82-a689-0247f2d5f6c0@kernel.org> <4196fe33-88c2-416d-ac20-b68bf7f328a6@linux.dev> From: David Ahern In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/26/26 9:53 PM, Zhu Yanjun wrote: >> That said, I don't have a strong preference, so up to you >> maintainers.  Simple lockless solution vs per-newlink/dellink >> locking. > To be honest, I do not have a strong preference here, though > > I lean slightly toward the per-newlink/dellink locking approach. > > Both the simple lockless solution and the locking approach seem > > reasonable, depending on whether we prioritize simplicity or > > explicit synchronization and lifecycle clarity. > > It would be helpful to get feedback from David Ahern, Leon, > > and Jason to converge on a final direction. Going in circles. I have said from the beginning of network namespace support for rxe do not open the port until first rxe device create and once opened leave it open. Simple design that limits socket churn to users wanting to leverage rxe in a network namespace. Zhu Yanjun, if you are going to be a maintainer of a feature you need to have a consistent stance on the architecture and code design.