From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH V1 for-next 1/2] IB/core: Report LSO capabilities when querying device Date: Tue, 10 May 2016 11:59:38 -0500 Message-ID: <9b7c01d1aadd$569dede0$03d9c9a0$@opengridcomputing.com> References: <21d9307f-766e-9aaa-54d3-207a4a4d5d8c@mellanox.com> <20160505181423.GB5957@obsidianresearch.com> <20160506225523.GA21309@obsidianresearch.com> <20160509163537.GA15479@obsidianresearch.com> <1828884A29C6694DAF28B7E6B8A82373AB04A390@ORSMSX109.amr.corp.intel.com> <20160509200507.GA23911@obsidianresearch.com> <1828884A29C6694DAF28B7E6B8A82373AB04A40A@ORSMSX109.amr.corp.intel.com> <0c0801d1aacd$280e52e0$782af8a0$@opengridcomputing.com> <20160510164608.GA29825@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160510164608.GA29825-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Content-Language: en-us Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Jason Gunthorpe' Cc: "'Hefty, Sean'" , 'Christoph Lameter' , 'Matan Barak' , 'Doug Ledford' , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Majd Dibbiny' , 'Bodong Wang' List-Id: linux-rdma@vger.kernel.org > > > I've been trying to follow this thread, and there has been comments that other > > device owners should speak up. But I'm not sure what LSO would do for an iWARP > > RC QP connection. Can someone give me a quick summary? > > It is unlikely someone would use LSO and an iWarp RC QP together. > > However, an iWarp NIC may want to expose the raw ethernet QP style of > feature, which would probably also want to include the LSO, RSS, > timestamping etc features. > Yes, that makes sense. Chelsio has something like this that is currently out-of-kernel. But there is no LSO/RSS support. And it needs major rewrite to become acceptable for inclusion upstream. But I can review the changes with this in mind. > Most likely iWarp cards already include LSO features in their > netdevice drivers? In that instance I'd say, imagine that same LSO > feature works on a verbs QP and ask if the patch covers the way it > works. > All of Chelsio's cards support LSO features (and all the other important NIC features). I'll think about the proposed API and if it would be sufficient for a RAW_QP type of service. Thanks for the summary Jason! Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html