Re: [PATCH v2 1/4] RDMA/core: add bio_vec based RDMA read/write API

[Chuck Lever <cel@kernel.org>]

On 1/21/26 3:56 AM, Christoph Hellwig wrote:
> Another reply, sorry.  I noticed I skipped over the end while reviewing
> the 3rd patch.
> 
>> +	u32 i, total_len = 0;
>> +
>> +	if (nr_bvec == 0 || offset >= bvec[0].bv_len)
>> +		return -EINVAL;
>> +
>> +		if (check_add_overflow(total_len, bvec[i].bv_len, &total_len))
>> +			return -EINVAL;
>> +	}
>> +	total_len -= offset;
>> +
>> +	iter.bi_sector = 0;
>> +	iter.bi_size = total_len;
>> +	iter.bi_idx = 0;
>> +	iter.bi_bvec_done = offset;
> 
> I'd much rather have the callers pass in the bvec_iter, as that's
> more useful.

"The callers" -- Can you clarify whether you mean that the API
consumers would pass in a bvec_iter, or whether the iter is
entirely internal to rw.c ?


> We can probably look into factoring the quoted code
> into a helper if that's useful.
> 


-- 
Chuck Lever