Re: [PATCH for-next v2 3/4] RDMA/erdma: Unify userspace and kernel queue buffer management

[Cheng Xu <chengyou@linux.alibaba.com>]

On 9/3/26 5:12 PM, Leon Romanovsky wrote:
> On Thu, Aug 27, 2026 at 04:25:22PM +0800, Cheng Xu wrote:
>> Userspace and kernel space queue buffers use separate helpers despite
>> sharing MTT metadata and lifetime rules. Manage both through
>> erdma_mem_init() and erdma_mem_uninit(), while keeping backing allocation
>> and release type-specific.
>>
>> Signed-off-by: Cheng Xu <chengyou@linux.alibaba.com>
>> ---
>>  drivers/infiniband/hw/erdma/erdma_verbs.c | 281 ++++++++++++++--------
>>  drivers/infiniband/hw/erdma/erdma_verbs.h |  17 +-
>>  2 files changed, 191 insertions(+), 107 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/erdma/erdma_verbs.c b/drivers/infiniband/hw/erdma/erdma_verbs.c
>> index b0a47c82cbdf..aaef2b3621b0 100644
>> --- a/drivers/infiniband/hw/erdma/erdma_verbs.c
>> +++ b/drivers/infiniband/hw/erdma/erdma_verbs.c
>> @@ -19,9 +19,9 @@
>>  #include "erdma_cm.h"
>>  #include "erdma_verbs.h"
> 
> <...>
> 
>> -static int get_mtt_entries(struct erdma_dev *dev, struct erdma_mem *mem,
>> -			   u64 start, u64 len, int access, u64 virt,
>> -			   unsigned long req_page_size, bool force_continuous)
>> +static void erdma_mem_free(struct erdma_dev *dev, struct erdma_mem *mem)
>>  {
>> -	int ret = 0;
>> +	switch (mem->type) {
>> +	case ERDMA_UMEM:
>> +		if (mem->umem) {
> 
> I expect that if you call to this function, mem->umem is already valid.
> 

Sure, I will fix it.

Thanks,
Cheng Xu

>> +			ib_umem_release(mem->umem);
>> +			mem->umem = NULL;
>> +		}
>> +		break;
>> +	case ERDMA_KMEM:
>> +		erdma_kmem_free(dev, mem);
>> +		break;
>> +	default:
>> +		break;
>> +	}
>> +}
>>  
> 
> Thanks