From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: Parav Pandit <parav@mellanox.com>,
"Latif, Faisal" <faisal.latif@intel.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Cc: Parav Pandit <parav@nvidia.com>
Subject: RE: [PATCH rdma-next] IB/i40iw: Avoid typecast from void to pci_dev
Date: Wed, 16 Sep 2020 14:53:19 +0000 [thread overview]
Message-ID: <9ce782da4c8a4872aa93c8bd737848c4@intel.com> (raw)
In-Reply-To: <20200914123528.270382-1-parav@mellanox.com>
> Subject: [PATCH rdma-next] IB/i40iw: Avoid typecast from void to pci_dev
>
> From: Parav Pandit <parav@nvidia.com>
>
> hw_context stores pci device pointer. Use the pci_dev pointer instead of void *
> and avoid typecasts.
>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +-
> drivers/infiniband/hw/i40iw/i40iw_pble.c | 4 ++--
> drivers/infiniband/hw/i40iw/i40iw_type.h | 3 ++-
> drivers/infiniband/hw/i40iw/i40iw_utils.c | 4 ++--
> drivers/infiniband/hw/i40iw/i40iw_verbs.c | 2 +-
> 5 files changed, 8 insertions(+), 7 deletions(-)
>
Looks good. Thanks Parav!
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
next prev parent reply other threads:[~2020-09-16 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 12:35 [PATCH rdma-next] IB/i40iw: Avoid typecast from void to pci_dev Parav Pandit
2020-09-16 14:53 ` Saleem, Shiraz [this message]
2020-09-16 16:44 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ce782da4c8a4872aa93c8bd737848c4@intel.com \
--to=shiraz.saleem@intel.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=parav@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).