public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: "Sean Hefty" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: 'Steve Wise'
	<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
	rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org
Cc: hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: [PATCH] ib_mad: Ignore iWARP devices on device removal.
Date: Thu, 4 Mar 2010 13:53:19 -0800	[thread overview]
Message-ID: <AFD61576933149C990D3373E7DF482F5@amr.corp.intel.com> (raw)
In-Reply-To: <20100304181818.18953.44421.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>

>When you unload an iWARP device, the ib_mad module logs errors.
>It should be ignoring iWARP devices on device removal just like it does
>on device add.
>
>Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Acked-by: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

>---
Looks okay to me.  Thanks, Steve.

>
> drivers/infiniband/core/mad.c |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c
>index 7522008..6216187 100644
>--- a/drivers/infiniband/core/mad.c
>+++ b/drivers/infiniband/core/mad.c
>@@ -2964,6 +2964,9 @@ static void ib_mad_remove_device(struct ib_device
>*device)
> {
> 	int i, num_ports, cur_port;
>
>+	if (rdma_node_get_transport(device->node_type) != RDMA_TRANSPORT_IB)
>+		return;
>+
> 	if (device->node_type == RDMA_NODE_IB_SWITCH) {
> 		num_ports = 1;
> 		cur_port = 0;


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2010-03-04 21:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04 18:18 [PATCH] ib_mad: Ignore iWARP devices on device removal Steve Wise
     [not found] ` <20100304181818.18953.44421.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2010-03-04 21:53   ` Sean Hefty [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AFD61576933149C990D3373E7DF482F5@amr.corp.intel.com \
    --to=sean.hefty-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    --cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox