Re: [PATCH v1 11/11] IB/rxe: Handle NETDEV_CHANGE events

Yuval Shaia
2017-08-27T10:30:10Z

On Fri, Aug 25, 2017 at 03:05:56PM -0400, Andrew Boyer wrote:
> Without this fix, ports configured on top of ixgbe miss link up
> notifications. ibv_query_port() will continue to return IBV_PORT_DOWN even
> though the port is up and working.
>
> Fixes: 8700e3e7c485 ("Soft RoCE driver")
> Signed-off-by: Andrew Boyer <andrew.boyer-8PEkshWhKlo@public.gmane.org>
> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
> index 3ba76e7..133c6c4 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -651,8 +651,13 @@ static int rxe_notify(struct notifier_block *not_blk,
> pr_info("%s changed mtu to %d\n", ndev->name, ndev->mtu);
> rxe_set_mtu(rxe, ndev->mtu);
> break;
> - case NETDEV_REBOOT:
> case NETDEV_CHANGE:
> + if (netif_running(ndev) && netif_carrier_ok(ndev))
> + rxe_port_up(rxe, port_num);

On top of which branch/patch this patch is based on?

> + else
> + rxe_port_down(rxe, port_num);
> + break;
> + case NETDEV_REBOOT:
> case NETDEV_GOING_DOWN:
> case NETDEV_CHANGEADDR:
> case NETDEV_CHANGENAME:
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html