Re: [PATCH v1 11/11] IB/rxe: Handle NETDEV_CHANGE events

Boyer, Andrew
2017-08-28T13:47:53Z

On 8/28/17, 9:37 AM, "Doug Ledford" <dledford@redhat.com> wrote:

>On 8/28/2017 8:38 AM, Boyer, Andrew wrote:
>>
>> On 8/27/17, 6:30 AM, "Yuval Shaia" <yuval.shaia@oracle.com> wrote:
>>
>>> On Fri, Aug 25, 2017 at 03:05:56PM -0400, Andrew Boyer wrote:
>>>> Without this fix, ports configured on top of ixgbe miss link up
>>>> notifications. ibv_query_port() will continue to return IBV_PORT_DOWN
>>>> even
>>>> though the port is up and working.
>>>>
>>>> Fixes: 8700e3e7c485 ("Soft RoCE driver")
>>>> Signed-off-by: Andrew Boyer <andrew.boyer@dell.com>
>>>> ---
>>>> drivers/infiniband/sw/rxe/rxe_net.c | 7 ++++++-
>>>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c
>>>> b/drivers/infiniband/sw/rxe/rxe_net.c
>>>> index 3ba76e7..133c6c4 100644
>>>> --- a/drivers/infiniband/sw/rxe/rxe_net.c
>>>> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
>>>> @@ -651,8 +651,13 @@ static int rxe_notify(struct notifier_block
>>>> *not_blk,
>>>> pr_info("%s changed mtu to %d\n", ndev->name, ndev->mtu);
>>>> rxe_set_mtu(rxe, ndev->mtu);
>>>> break;
>>>> - case NETDEV_REBOOT:
>>>> case NETDEV_CHANGE:
>>>> + if (netif_running(ndev) && netif_carrier_ok(ndev))
>>>> + rxe_port_up(rxe, port_num);
>>> On top of which branch/patch this patch is based on?
>> Yikes, it relies on an internal patch that Doug wasn¹t interested in
>> taking. Will respin.
>>
>
>I don't remember seeing a patch come through that added rxe_port_up(),
>let alone turning it away...

It’s the port_num argument that doesn’t exist upstream. We added the
ability for RXE to support a second port (to better mimic an mlx4) but you
said it wasn’t needed.

-Andrew

>
>--
>Doug Ledford <dledford@redhat.com>
> GPG Key ID: B826A3330E572FDD
> Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
>