Re: [RFC net-next 15/17] net/dibs: Move query_remote_gid() to dibs_dev_ops

["Julian Ruess" <julianr@linux.ibm.com>]

On Wed Aug 6, 2025 at 5:41 PM CEST, Alexandra Winter wrote:
> Provide the dibs_dev_ops->query_remote_gid() in ism and dibs_loopback
> dibs_devices. And call it in smc dibs_client.
>
> Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
> Reviewed-by: Julian Ruess <julianr@linux.ibm.com>
> ---
>  drivers/s390/net/ism_drv.c | 41 +++++++++++++++++---------------------
>  include/linux/dibs.h       | 14 +++++++++++++
>  include/net/smc.h          |  2 --
>  net/dibs/dibs_loopback.c   | 10 ++++++++++
>  net/smc/smc_ism.c          |  8 ++++++--
>  net/smc/smc_loopback.c     | 13 ------------
>  6 files changed, 48 insertions(+), 40 deletions(-)
>

-- snip --

> diff --git a/include/linux/dibs.h b/include/linux/dibs.h
> index 10be10ae4660..d940411aa179 100644
> --- a/include/linux/dibs.h
> +++ b/include/linux/dibs.h
> @@ -133,6 +133,20 @@ struct dibs_dev_ops {
>  	 * Return: 2 byte dibs fabric id
>  	 */
>  	u16 (*get_fabric_id)(struct dibs_dev *dev);
> +	/**
> +	 * query_remote_gid()
> +	 * @dev: local dibs device
> +	 * @rgid: gid of remote dibs device
> +	 * @vid_valid: if zero, vid will be ignored;
> +	 *	       deprecated, ignored if device does not support vlan
> +	 * @vid: VLAN id; deprecated, ignored if device does not support vlan
> +	 *
> +	 * Query whether a remote dibs device is reachable via this local device
> +	 * and this vlan id.
> +	 * Return: 0 if remote gid is reachable.
> +	 */
> +	int (*query_remote_gid)(struct dibs_dev *dev, uuid_t *rgid,
> +				u32 vid_valid, u32 vid);

Shouldn't this be 'const uuid_t *rgid'?

-- snip --

Thanks,
Julian