From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next v2 1/4] RDMA/rxe: Replace exists by rxe in rxe.c
Date: Fri, 24 Feb 2023 08:35:03 -0400 [thread overview]
Message-ID: <Y/iu948rjXh9Kj0W@nvidia.com> (raw)
In-Reply-To: <20230224032916.151490-2-rpearsonhpe@gmail.com>
On Thu, Feb 23, 2023 at 09:29:15PM -0600, Bob Pearson wrote:
> 'exists' looks like a boolean. This patch replaces it by the
> normal name used for the rxe device, 'rxe', which should be a
> little less confusing. The second rxe_dbg() message is
> incorrect since rxe is known to be NULL and this will cause a
> seg fault if this message were ever sent. Replace it by pr_debug
> for the moment.
>
> Fixes: c6aba5ea0055 ("RDMA/rxe: Replace pr_xxx by rxe_dbg_xxx in rxe.c")
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> ---
> drivers/infiniband/sw/rxe/rxe.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
I don't mind this, but have you thought about instrumenting it
properly with tracepoints?
Jason
next prev parent reply other threads:[~2023-02-24 12:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 3:29 [PATCH for-next v2 0/4] Add error logging to rxe Bob Pearson
2023-02-24 3:29 ` [PATCH for-next v2 1/4] RDMA/rxe: Replace exists by rxe in rxe.c Bob Pearson
2023-02-24 12:35 ` Jason Gunthorpe [this message]
2023-02-24 3:29 ` [PATCH for-next v2 2/4] RDMA/rxe: Change rxe_dbg to rxe_dbg_dev Bob Pearson
2023-02-24 3:29 ` [PATCH for-next v2 3/4] RDMA/rxe: Extend dbg log messages to err and info Bob Pearson
2023-02-24 3:29 ` [PATCH for-next v2 4/4] RDMA/rxe: Add error messages Bob Pearson
2023-02-24 17:06 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/iu948rjXh9Kj0W@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox