Re: A question about FAILOVER event in RoCE LAG

[Leon Romanovsky <leon@kernel.org>]

+Mark

On Fri, Feb 24, 2023 at 11:14:47AM +0000, huangjunxian (C) wrote:
> Hi folks!
> 
> We've been working on LAG in hns RoCE driver, and we notice that when a FAILOVER event
> occurs in active-backup mode, all GIDs of the RDMA bond device are deleted and new GIDs
> are added, triggered by the event handler listed below.
> 
> So, when a FAILOVER event occurs on a RDMA bond device with running traffic, does it make
> sense that the traffic is terminated since its GIDs are deleted?
> 
> The FAILOVER event handler mentioned above:
> static int netdevice_event(struct notifier_block *this, unsigned long event, void *ptr)
> {
>          ......
>          static const struct netdev_event_work_cmd bonding_event_ips_del_cmd = {
>                   .cb = del_netdev_upper_ips, .filter = upper_device_filter};
>          ......
>          switch (event) {
>          ......
>          case NETDEV_BONDING_FAILOVER:
>                   cmds[0] = bonding_event_ips_del_cmd;
>                   /* Add default GIDs of the bond device */
>                   cmds[1] = bonding_default_add_cmd;
>                   /* Add IP based GIDs of the bond device */
>                   cmds[2] = add_cmd_upper_ips;
>                   break;
>          ......
>          }
>          ......
> }
> 
> Thanks,
> Junxian