Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: leonro@nvidia.com,
	Brendan Cunningham <bcunningham@cornelisnetworks.com>,
	Patrick Kelsey <pat.kelsey@cornelisnetworks.com>,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next 0/3] Respin: Rework system pinning
Date: Fri, 17 Feb 2023 16:41:12 -0400	[thread overview]
Message-ID: <Y+/maP/69VMafscx@nvidia.com> (raw)
In-Reply-To: <167656602090.2223096.15523567129751109800.stgit@awfm-02.cornelisnetworks.com>

On Thu, Feb 16, 2023 at 11:56:18AM -0500, Dennis Dalessandro wrote:
> This is a respin on top of the latest rdma/for-next branch
> of the series being discussed on the list here:
> https://lore.kernel.org/linux-rdma/Y+EbyU4HkGyzPoFO@nvidia.com/T/#ma3d153151adf1dbe2b9800000fa9a01f95a80c1f
> 
> We have added fixes lines, and Brendan has discovered a couple code hunks that
> do not need to be here in this submission. We have also removed the stats stuff
> until the user side code is readily available.
> 
> ---
> 
> Patrick Kelsey (3):
>       IB/hfi1: Fix math bugs in hfi1_can_pin_pages()
>       IB/hfi1: Fix sdma.h tx->num_descs off-by-one errors

I took these two

>       IB/hfi1: Do SDMA memory-pinning through hfi1's pinning interface

But really? This is almost a thousand lines in just one patch, is that
really justified? Can you break it up?

Jason

  parent reply	other threads:[~2023-02-17 20:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 16:56 [PATCH for-next 0/3] Respin: Rework system pinning Dennis Dalessandro
2023-02-16 16:56 ` [PATCH for-next 1/3] IB/hfi1: Fix math bugs in hfi1_can_pin_pages() Dennis Dalessandro
2023-02-16 16:56 ` [PATCH for-next 2/3] IB/hfi1: Fix sdma.h tx->num_descs off-by-one errors Dennis Dalessandro
2023-02-16 16:56 ` [PATCH for-next 3/3] IB/hfi1: Do SDMA memory-pinning through hfi1's pinning interface Dennis Dalessandro
2023-02-17 20:41 ` Jason Gunthorpe [this message]
2023-02-17 21:40   ` [PATCH for-next 0/3] Respin: Rework system pinning Dennis Dalessandro
2023-02-18 15:59     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+/maP/69VMafscx@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=bcunningham@cornelisnetworks.com \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=leonro@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=pat.kelsey@cornelisnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox