From: Jason Gunthorpe <jgg@nvidia.com>
To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: leonro@nvidia.com,
Brendan Cunningham <bcunningham@cornelisnetworks.com>,
Patrick Kelsey <pat.kelsey@cornelisnetworks.com>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next v2 1/3] IB/hfi1: Fix math bugs in hfi1_can_pin_pages()
Date: Thu, 16 Feb 2023 11:12:22 -0400 [thread overview]
Message-ID: <Y+5H1nw0Kyse8xyi@nvidia.com> (raw)
In-Reply-To: <167467689891.3649436.5979603883827786631.stgit@awfm-02.cornelisnetworks.com>
On Wed, Jan 25, 2023 at 03:01:38PM -0500, Dennis Dalessandro wrote:
> From: Patrick Kelsey <pat.kelsey@cornelisnetworks.com>
>
> Fix arithmetic and logic errors in hfi1_can_pin_pages() that would allow
> hfi1 to attempt pinning pages in cases where it should not because of
> resource limits or lack of required capability.
>
> Signed-off-by: Brendan Cunningham <bcunningham@cornelisnetworks.com>
> Signed-off-by: Patrick Kelsey <pat.kelsey@cornelisnetworks.com>
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> ---
> drivers/infiniband/hw/hfi1/user_pages.c | 61 ++++++++++++++++++++-----------
> 1 file changed, 40 insertions(+), 21 deletions(-)
I was going to take these first two patches, but where are the fixes
lines for things that are clearly bug fixes?
Jason
next prev parent reply other threads:[~2023-02-16 15:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 20:01 [PATCH for-next v2 0/3] Rework system pinning Dennis Dalessandro
2023-01-25 20:01 ` [PATCH for-next v2 1/3] IB/hfi1: Fix math bugs in hfi1_can_pin_pages() Dennis Dalessandro
2023-02-16 15:12 ` Jason Gunthorpe [this message]
2023-02-16 16:18 ` Dennis Dalessandro
2023-01-25 20:01 ` [PATCH for-next v2 2/3] IB/hfi1: Fix sdma.h tx->num_descs off-by-one errors Dennis Dalessandro
2023-01-25 20:01 ` [PATCH for-next v2 3/3] IB/hfi1: Do all memory-pinning through hfi1's pinning interface Dennis Dalessandro
2023-02-06 11:03 ` [PATCH for-next v2 0/3] Rework system pinning Leon Romanovsky
2023-02-06 14:17 ` Dennis Dalessandro
2023-02-06 15:24 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+5H1nw0Kyse8xyi@nvidia.com \
--to=jgg@nvidia.com \
--cc=bcunningham@cornelisnetworks.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=pat.kelsey@cornelisnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).