Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org, rpearson@hpe.com
Subject: Re: [PATCH for-next] RDMA/rxe: Remove rxe_alloc()
Date: Thu, 16 Feb 2023 11:59:26 -0400	[thread overview]
Message-ID: <Y+5S3uivQvdJZ3qY@nvidia.com> (raw)
In-Reply-To: <20230213225551.12437-1-rpearsonhpe@gmail.com>

On Mon, Feb 13, 2023 at 04:55:52PM -0600, Bob Pearson wrote:
> Currently all the object types in the rxe driver are allocated in
> rdma-core except for MRs. By moving tha kzalloc() call outside of
> the pool code the rxe_alloc() subroutine can be eliminated and code
> checking for MR as a special case can be removed.
> 
> This patch moves the kzalloc() and kfree_rcu() calls into the mr
> registration and destruction verbs. It removes that code from
> rxe_pool.c including the rxe_alloc() subroutine which is no longer
> used.
> 
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> Reviewed-by: Devesh Sharma <devesh.s.sharma@oracle.com>
> Reviewed-by: Devesh Sharma <devesh.s.sharma@oracle.com>
> Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
>  drivers/infiniband/sw/rxe/rxe_mr.c    |  2 +-
>  drivers/infiniband/sw/rxe/rxe_pool.c  | 46 --------------------
>  drivers/infiniband/sw/rxe/rxe_pool.h  |  3 --
>  drivers/infiniband/sw/rxe/rxe_verbs.c | 61 +++++++++++++++++++--------
>  4 files changed, 45 insertions(+), 67 deletions(-)

Applied to for-next, thanks

Jason

      parent reply	other threads:[~2023-02-16 15:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 22:55 [PATCH for-next] RDMA/rxe: Remove rxe_alloc() Bob Pearson
2023-02-14  4:15 ` Devesh Sharma
2023-02-14 17:33   ` Pearson, Robert B
2023-02-14 23:55 ` Zhu Yanjun
2023-02-16 15:59 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+5S3uivQvdJZ3qY@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rpearson@hpe.com \
    --cc=rpearsonhpe@gmail.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox