Re: [PATCH rdma-rc] RDMA/cma: Use output interface for net_dev check

[Leon Romanovsky <leon@kernel.org>]

On Wed, Oct 12, 2022 at 04:15:42PM +0200, Håkon Bugge wrote:
> Commit 27cfde795a96 ("RDMA/cma: Fix arguments order in net device
> validation") swapped the src and dst addresses in the call to
> validate_net_dev().
> 
> As a consequence, the test in validate_ipv4_net_dev() to see if the
> net_dev is the right one, is incorrect for port 1 <-> 2 communication
> when the ports are on the same sub-net. This is fixed by denoting the
> flowi4_oif as the device instead of the incoming one.
> 
> The bug has not been observed using IPv6 addresses.
> 
> Fixes: 27cfde795a96 ("RDMA/cma: Fix arguments order in net device validation")
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
> ---
>  drivers/infiniband/core/cma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>