From: Jason Gunthorpe <jgg@nvidia.com>
To: "xuhaoyue (A)" <xuhaoyue1@hisilicon.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH v2 for-rc 3/5] RDMA/hns: Remove enable rq inline in kernel and add compatibility handling
Date: Mon, 31 Oct 2022 09:07:43 -0300 [thread overview]
Message-ID: <Y1+6j7KwbG9ls/25@nvidia.com> (raw)
In-Reply-To: <9b50dae1-e448-047b-8a54-489ff120f00c@hisilicon.com>
On Mon, Oct 31, 2022 at 04:23:14PM +0800, xuhaoyue (A) wrote:
> This bit is used to prevent compatibility issues in the old
> kernel. It is not for compatibility with userspace. It should be a
> bugfix. I will separate this into a new bugfix patch. I will change
> the name to __HNS_ROCE_CAP_FLAG_RQ_INLINE in V3.
There is no such thing as "compatability issues in the old kernel"
If it is used then name it sensibly, if it isn't then delete it.
Jason
next prev parent reply other threads:[~2022-10-31 12:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 9:50 [PATCH v2 for-rc 0/5] Fix sge_num bug and add cqe inline, refactor rq inline Haoyue Xu
2022-10-26 9:50 ` [PATCH v2 for-rc 1/5] RDMA/hns: Fix ext_sge num error when post send Haoyue Xu
2022-10-26 9:50 ` [PATCH v2 for-rc 2/5] RDMA/hns: Fix the problem of sge nums Haoyue Xu
2022-10-28 16:42 ` Jason Gunthorpe
2022-10-29 9:47 ` xuhaoyue (A)
2022-10-26 9:50 ` [PATCH v2 for-rc 3/5] RDMA/hns: Remove enable rq inline in kernel and add compatibility handling Haoyue Xu
2022-10-28 16:40 ` Jason Gunthorpe
2022-10-31 8:23 ` xuhaoyue (A)
2022-10-31 12:07 ` Jason Gunthorpe [this message]
2022-11-03 12:50 ` xuhaoyue (A)
2022-10-26 9:50 ` [PATCH v2 for-rc 4/5] RDMA/hns: Remove rq inline in kernel Haoyue Xu
2022-10-26 9:50 ` [PATCH v2 for-rc 5/5] RDMA/hns: Support cqe inline in user space Haoyue Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1+6j7KwbG9ls/25@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=xuhaoyue1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox