From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DB5FA373E for ; Mon, 24 Oct 2022 12:08:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232796AbiJXMIO (ORCPT ); Mon, 24 Oct 2022 08:08:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232661AbiJXMG3 (ORCPT ); Mon, 24 Oct 2022 08:06:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D9187E31E for ; Mon, 24 Oct 2022 04:51:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B919161257 for ; Mon, 24 Oct 2022 11:51:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A15A5C43470; Mon, 24 Oct 2022 11:51:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666612300; bh=5K4AwVYm4+lHrKZsPJyon9OIUN48UG10z3hs1NxGzGU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VSg0TGssng1nJPkB8hdNqK2ObMrXi46EqhCy5IIedkk4QRnghs3C2kZKMy9LnSKNA kz+aAoMdDuM7HGwT6bJ8iNAb5JGnm1dla+58UYlpMYVthm3oEuAdTrMqlwjZ03yPJN l1jxZ4GZoEhGiZ0RHzoKmoz03uJ1vV1q5nuM7AzNldw0TXnKhU1BV4OopcJRC3kI+/ phIUhmyC3zVmv9HtWP/wFCe8a0kF/Slr5w6qzaYQX1FKvTrSyPHagE1S7LJsO3IzV1 o9XwMscdPE5ETpo3a4Xq1djE03gH9ciRB9qW9WBgb+OX8t4SGetK3aN37Z5wNzsZU/ zuUSMCQPAdr9w== Date: Mon, 24 Oct 2022 14:51:35 +0300 From: Leon Romanovsky To: "yangx.jy@fujitsu.com" Cc: "linux-rdma@vger.kernel.org" , "jgg@ziepe.ca" Subject: Re: [PATCH] RDMA/rxe: Remove the member 'type' of struct rxe_mr Message-ID: References: <20221021134513.17730-1-yangx.jy@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221021134513.17730-1-yangx.jy@fujitsu.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Oct 21, 2022 at 01:45:17PM +0000, yangx.jy@fujitsu.com wrote: > The member 'type' is included in both struct rxe_mr and struct ib_mr > so remove the duplicate one of struct rxe_mr. > > Signed-off-by: Xiao Yang > --- > drivers/infiniband/sw/rxe/rxe_mr.c | 16 ++++++++-------- > drivers/infiniband/sw/rxe/rxe_verbs.h | 1 - > 2 files changed, 8 insertions(+), 9 deletions(-) <...> > default: > pr_warn("%s: mr type (%d) not supported\n", > - __func__, mr->type); > + __func__, mr->ibmr.type); > return -EFAULT; <...> > - if (unlikely(mr->type != IB_MR_TYPE_MEM_REG)) { > - pr_warn("%s: mr->type (%d) is wrong type\n", __func__, mr->type); > + if (unlikely(mr->ibmr.type != IB_MR_TYPE_MEM_REG)) { > + pr_warn("%s: mr type (%d) is wrong\n", __func__, mr->ibmr.type); Someone needs to convert pr_*() calls to ibdev_*() prints. Thanks