Re: [PATCH] RDMA/rxe: Remove the member 'type' of struct rxe_mr

Leon Romanovsky
2022-10-24T12:08:16Z

On Fri, Oct 21, 2022 at 01:45:17PM +0000, yangx.jy@fujitsu.com wrote:
> The member 'type' is included in both struct rxe_mr and struct ib_mr
> so remove the duplicate one of struct rxe_mr.
>
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
> ---
> drivers/infiniband/sw/rxe/rxe_mr.c | 16 ++++++++--------
> drivers/infiniband/sw/rxe/rxe_verbs.h | 1 -
> 2 files changed, 8 insertions(+), 9 deletions(-)

<...>

> default:
> pr_warn("%s: mr type (%d) not supported\n",
> - __func__, mr->type);
> + __func__, mr->ibmr.type);
> return -EFAULT;

<...>

> - if (unlikely(mr->type != IB_MR_TYPE_MEM_REG)) {
> - pr_warn("%s: mr->type (%d) is wrong type\n", __func__, mr->type);
> + if (unlikely(mr->ibmr.type != IB_MR_TYPE_MEM_REG)) {
> + pr_warn("%s: mr type (%d) is wrong\n", __func__, mr->ibmr.type);

Someone needs to convert pr_*() calls to ibdev_*() prints.

Thanks