Re: [PATCH v2 for-rc 3/5] RDMA/hns: Remove enable rq inline in kernel and add compatibility handling

xuhaoyue (A)
2022-11-03T12:51:06Z

You are right. This enum has gone wrong here. I will fix in the V3.

On 2022/10/31 20:07:43, Jason Gunthorpe wrote:
> On Mon, Oct 31, 2022 at 04:23:14PM +0800, xuhaoyue (A) wrote:
>
>> This bit is used to prevent compatibility issues in the old
>> kernel. It is not for compatibility with userspace. It should be a
>> bugfix. I will separate this into a new bugfix patch. I will change
>> the name to __HNS_ROCE_CAP_FLAG_RQ_INLINE in V3.
>
> There is no such thing as "compatability issues in the old kernel"
>
> If it is used then name it sensibly, if it isn't then delete it.
>
> Jason
> .
>