Re: [PATCH v2 for-rc 2/5] RDMA/hns: Fix the problem of sge nums

xuhaoyue (A)
2022-10-29T09:47:41Z

I will change it in V3.

On 2022/10/29 0:42:03, Jason Gunthorpe wrote:
> On Wed, Oct 26, 2022 at 05:50:51PM +0800, Haoyue Xu wrote:
>> From: Luoyouming <luoyouming@huawei.com>
>>
>> Currently, the driver only uses max_send_sge to initialize sge num
>> when creating_qp. So, in the sq inline scenario, the driver may not
>> has enough sge to send data. For example, if max_send_sge is 16 and
>> max_inline_data is 1024, the driver needs 1024/16=64 sge to send data.
>> Therefore, the calculation method of sge num is modified to take the
>> maximum value of max_send_sge and max_inline_data/16 to solve this
>> problem.
>>
>> Fixes: 05201e01be93 ("RDMA/hns: Refactor process of setting extended sge")
>> Fixes: 30b707886aeb ("RDMA/hns: Support inline data in extented sge space for RC")
>>
>> Signed-off-by: Luoyouming <luoyouming@huawei.com>
>> Signed-off-by: Haoyue Xu <xuhaoyue1@hisilicon.com>
>> ---
>> drivers/infiniband/hw/hns/hns_roce_device.h | 3 +
>> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 12 +--
>> drivers/infiniband/hw/hns/hns_roce_main.c | 18 +++-
>> drivers/infiniband/hw/hns/hns_roce_qp.c | 108 +++++++++++++++++---
>> include/uapi/rdma/hns-abi.h | 17 +++
>> 5 files changed, 128 insertions(+), 30 deletions(-)
>
> There should be no space after the fixes line, please check all
> patches
>
> Also this entire series seems unsuitable to go into for-rc
>
> You need to justify the impact of each rc patch in the commit message,
> and nearly evey rc patch should have a fixes tag.
>
> Make the first two patches are OK for -rc, but they should have better
> commit messages.
>
> Jason
> .
>