From: Leon Romanovsky <leon@kernel.org>
To: Leonid Ravich <lravich@gmail.com>
Cc: jgg@ziepe.ca, mhiramat@kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/MAD: fix might sleep in atomic
Date: Thu, 10 Nov 2022 11:00:43 +0200 [thread overview]
Message-ID: <Y2y9u7Lz7bxYUOqJ@unreal> (raw)
In-Reply-To: <Y2t5feomyznrVj7V@leonid-Inspiron-3421>
On Wed, Nov 09, 2022 at 11:57:17AM +0200, Leonid Ravich wrote:
> Sleep in TR_assign not allowd
>
> WARNING: CPU: 0 PID: 1888000 at kernel/trace/ring_buffer.c:2492 rb_commit+0xc1/0x220
> CPU: 0 PID: 1888000 Comm: kworker/u9:0 Kdump: loaded Tainted: G OE --------- - - 4.18.0-305.3.1.el8.x86_64 #1
> l: Hardware name: Red Hat KVM, BIOS 1.13.0-2.module_el8.3.0+555+a55c8938 04/01/2014
> l: Workqueue: ib-comp-unb-wq ib_cq_poll_work [ib_core]
> l: RIP: 0010:rb_commit+0xc1/0x220
> l: RSP: 0000:ffffa8ac80f9bca0 EFLAGS: 00010202
> l: RAX: ffff8951c7c01300 RBX: ffff8951c7c14a00 RCX: 0000000000000246
> l: RDX: ffff8951c707c000 RSI: ffff8951c707c57c RDI: ffff8951c7c14a00
> l: RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
> l: R10: ffff8951c7c01300 R11: 0000000000000001 R12: 0000000000000246
> l: R13: 0000000000000000 R14: ffffffff964c70c0 R15: 0000000000000000
> l: FS: 0000000000000000(0000) GS:ffff8951fbc00000(0000) knlGS:0000000000000000
> l: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> l: CR2: 00007f20e8f39010 CR3: 000000002ca10005 CR4: 0000000000170ef0
> l: Call Trace:
> l: ring_buffer_unlock_commit+0x1d/0xa0
> l: trace_buffer_unlock_commit_regs+0x3b/0x1b0
> l: trace_event_buffer_commit+0x67/0x1d0
> l: trace_event_raw_event_ib_mad_recv_done_handler+0x11c/0x160 [ib_core]
> l: ib_mad_recv_done+0x48b/0xc10 [ib_core]
> l: ? trace_event_raw_event_cq_poll+0x6f/0xb0 [ib_core]
> l: __ib_process_cq+0x91/0x1c0 [ib_core]
> l: ib_cq_poll_work+0x26/0x80 [ib_core]
> l: process_one_work+0x1a7/0x360
> l: ? create_worker+0x1a0/0x1a0
> l: worker_thread+0x30/0x390
> l: ? create_worker+0x1a0/0x1a0
> l: kthread+0x116/0x130
> l: ? kthread_flush_work_fn+0x10/0x10
> l: ret_from_fork+0x35/0x40
> l: ---[ end trace 78ba8509d3830a16 ]---
>
> Signed-off-by: Leonid Ravich <lravich@gmail.com>
> ---
> drivers/infiniband/core/mad.c | 3 ---
> include/trace/events/ib_mad.h | 13 ++++---------
> 2 files changed, 4 insertions(+), 12 deletions(-)
make[4]: *** [scripts/Makefile.build:250: drivers/infiniband/core/mad.o] Error 1
drivers/infiniband/core/mad.c:62:20: error: unused variable 'dev' [-Werror,-Wunused-variable]
struct ib_device *dev = qp_info->port_priv->device;
^
drivers/infiniband/core/mad.c:63:6: error: unused variable 'pnum' [-Werror,-Wunused-variable]
u32 pnum = qp_info->port_priv->port_num;
^
2 errors generated.
I fixed it together with commit message and applied.
Thanks
next prev parent reply other threads:[~2022-11-10 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 9:57 [PATCH] IB/MAD: fix might sleep in atomic Leonid Ravich
2022-11-10 9:00 ` Leon Romanovsky [this message]
2022-11-10 9:01 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2y9u7Lz7bxYUOqJ@unreal \
--to=leon@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lravich@gmail.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox