public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: rpearsonhpe@gmail.com
Cc: linux-rdma@vger.kernel.org
Subject: [bug report] RDMA/rxe: Replace pr_xxx by rxe_dbg_xxx in rxe_mr.c
Date: Fri, 18 Nov 2022 18:00:53 +0300	[thread overview]
Message-ID: <Y3eeJW0AdyJYhYyQ@kili> (raw)

Hello Bob Pearson,

This is a semi-automatic email about new static checker warnings.

The patch 2778b72b1df0: "RDMA/rxe: Replace pr_xxx by rxe_dbg_xxx in 
rxe_mr.c" from Nov 3, 2022, leads to the following Smatch complaint:

    drivers/infiniband/sw/rxe/rxe_mr.c:527 rxe_invalidate_mr()
    error: we previously assumed 'mr' could be null (see line 526)

drivers/infiniband/sw/rxe/rxe_mr.c
   525		mr = rxe_pool_get_index(&rxe->mr_pool, key >> 8);
   526		if (!mr) {
                    ^^^
"mr" is NULL.

   527			rxe_dbg_mr(mr, "No MR for key %#x\n", key);
                                   ^^
Dereference.

   528			ret = -EINVAL;
   529			goto err;

regards,
dan carpenter

             reply	other threads:[~2022-11-18 15:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18 15:00 Dan Carpenter [this message]
2022-11-22 19:40 ` [bug report] RDMA/rxe: Replace pr_xxx by rxe_dbg_xxx in rxe_mr.c Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3eeJW0AdyJYhYyQ@kili \
    --to=error27@gmail.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rpearsonhpe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox