Re: [PATCH 1/2 v2] IB/qib: don't use qib_wc_x86_64 for UML

Leon Romanovsky
2022-12-01T10:12:39Z

On Thu, Dec 01, 2022 at 10:28:18AM +0100, Johannes Berg wrote:
> On Thu, 2022-12-01 at 11:22 +0200, Leon Romanovsky wrote:
> >
> > > +++ b/drivers/infiniband/hw/qib/Kconfig
> > > @@ -3,6 +3,7 @@ config INFINIBAND_QIB
> > > tristate "Intel PCIe HCA support"
> > > depends on 64BIT && INFINIBAND_RDMAVT
> > > depends on PCI
> > > + depends on !UML
> >
> > I would advocate to add this line to whole drivers/infiniband.
> > None of RDMA code makes sense for UML.
> >
>
> You could argue that one might want to eventually use kunit for some
> bits and pieces in there, so it'd make sense to be able to build the
> parts that _can_ be built, but I have no idea :)

But now, we don't have anyone in RDMA who uses kunit. Once it will be
needed, he/she will extend drivers/infiniband to support it.

Thanks

>
> johannes