From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF02C54EBC for ; Tue, 10 Jan 2023 16:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233653AbjAJQaR (ORCPT ); Tue, 10 Jan 2023 11:30:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233014AbjAJQaP (ORCPT ); Tue, 10 Jan 2023 11:30:15 -0500 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DE3D6133C for ; Tue, 10 Jan 2023 08:30:13 -0800 (PST) Received: by mail-pl1-x642.google.com with SMTP id 17so13782833pll.0 for ; Tue, 10 Jan 2023 08:30:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4g3X2Drb8iDIejSiH0zFfNh5MOmbpVh8uX0CGV33Ygw=; b=jie1h2bF6T0loL1kylf5SLvyS0ttCfxL/U79701D7Jc+1IkfwixBN4MpGFNc441I8n rl0JBa3hUIvLS36GCdBIOkhpDcy/IDVIRWp/yuSg7PBI5ZSeQGLc7GZdZZgOKi+pYn0C HTRafMDZ1/gTGXGHjLx51tT+oXyMQxAoExxDwWKMu+++bGjk/5umgA8bQERjXhqxXTRy Q9uLnPmQ95UgBpIOzxuMsD6nfq/g9vJjvXaGHSOn42vQFuUVv2v8Y65qSxqIntgEXMLY 0eahvmjKtp0NDUvPgAIpo38znxs8UvEjKhKVEiFgKQ6tmpjKA3pplJfAAcTpVJ3Ija0e kXNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4g3X2Drb8iDIejSiH0zFfNh5MOmbpVh8uX0CGV33Ygw=; b=VL1u6jTs83i4xoIAG+BpwDsDhIOeY4sZZrGT6zQITKrGCRmJEChe84Qo8kYocTyArc l9IuIESLkdqytfuSDGZGW55zJ0VqiXypWsrqYCYGsU7ozgOnfWmQQpJM/NGgGb76j9Hy sZ5skjSxBwtF15VwdFF01T5NXN1drvUqKvW474iPo89RbH5A8axVi2wtugZHnF1PX6Vk bcswFvYqONBc0w9gJRP3uQKFNIRURi2xNX9EHtd6+9q/mmHkErk2xeiHmp6GuLKfnNGz Wi4e/+HLXyga/n/uZZNnRoEuCtlOCrJthPJ1/BiW/0Rgj0Lz1MekqzHRW3+UA2WHdL+X QHUg== X-Gm-Message-State: AFqh2koH9OuGEt99/bBmhnx9lY0qzVXtP6WakGvf9MHyfFA5SHavMTfb ueFh9ElFsBF+rEtBIBJh6zrIQw== X-Google-Smtp-Source: AMrXdXsXyTXOJDg2HvTe03JJzllkrApnnxWjeSXx+w/qB5rYUlhFrZp6dWVQvcOJHGx4CRPsdXmaHQ== X-Received: by 2002:a17:90b:3557:b0:219:bd64:8e60 with SMTP id lt23-20020a17090b355700b00219bd648e60mr73264459pjb.34.1673368213082; Tue, 10 Jan 2023 08:30:13 -0800 (PST) Received: from localhost (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id y7-20020a17090a154700b002265ddfc13esm3213456pja.29.2023.01.10.08.30.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 08:30:12 -0800 (PST) Date: Tue, 10 Jan 2023 17:30:09 +0100 From: Jiri Pirko To: Kees Cook Cc: Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Gustavo A. R. Silva" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] net/mlx5e: Replace 0-length array with flexible array Message-ID: References: <20230105223642.never.980-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105223642.never.980-kees@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Thu, Jan 05, 2023 at 11:36:43PM CET, keescook@chromium.org wrote: >Zero-length arrays are deprecated[1]. Replace struct mlx5e_rx_wqe_cyc's >"data" 0-length array with a flexible array. Detected with GCC 13, >using -fstrict-flex-arrays=3: > >drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_alloc_rq': >drivers/net/ethernet/mellanox/mlx5/core/en_main.c:827:42: warning: array subscript f is outside array bounds of 'struct mlx5_wqe_data_seg[0]' [-Warray-bounds=] > 827 | wqe->data[f].byte_count = 0; > | ~~~~~~~~~^~~ >In file included from drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.h:11, > from drivers/net/ethernet/mellanox/mlx5/core/eswitch.h:48, > from drivers/net/ethernet/mellanox/mlx5/core/en_main.c:42: >drivers/net/ethernet/mellanox/mlx5/core/en.h:250:39: note: while referencing 'data' > 250 | struct mlx5_wqe_data_seg data[0]; > | ^~~~ > >[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays > >Cc: Saeed Mahameed >Cc: Leon Romanovsky >Cc: "David S. Miller" >Cc: Eric Dumazet >Cc: Jakub Kicinski >Cc: Paolo Abeni >Cc: "Gustavo A. R. Silva" >Cc: netdev@vger.kernel.org >Cc: linux-rdma@vger.kernel.org >Signed-off-by: Kees Cook Reviewed-by: Jiri Pirko