From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Long Li <longli@microsoft.com>,
Ajay Sharma <sharmaajay@microsoft.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Dexuan Cui <decui@microsoft.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] RDMA/mana_ib: Prevent array underflow in mana_ib_create_qp_raw()
Date: Thu, 26 Jan 2023 14:18:53 +0200 [thread overview]
Message-ID: <Y9JvrfOezthLscEP@unreal> (raw)
In-Reply-To: <Y9JdXfJvGhrJeLF7@kadam>
On Thu, Jan 26, 2023 at 02:00:45PM +0300, Dan Carpenter wrote:
> On Thu, Jan 26, 2023 at 12:18:46PM +0200, Leon Romanovsky wrote:
> > On Tue, Jan 24, 2023 at 06:20:54PM +0300, Dan Carpenter wrote:
> > > The "port" comes from the user and if it is zero then the:
> > >
> > > ndev = mc->ports[port - 1];
> > >
> > > assignment does an out of bounds read. I have changed the if
> > > statement to fix this and to mirror how it is done in
> > > mana_ib_create_qp_rss().
> > >
> > > Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
> > > Signed-off-by: Dan Carpenter <error27@gmail.com>
> > > ---
> > > drivers/infiniband/hw/mana/qp.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/infiniband/hw/mana/qp.c b/drivers/infiniband/hw/mana/qp.c
> > > index ea15ec77e321..54b61930a7fd 100644
> > > --- a/drivers/infiniband/hw/mana/qp.c
> > > +++ b/drivers/infiniband/hw/mana/qp.c
> > > @@ -289,7 +289,7 @@ static int mana_ib_create_qp_raw(struct ib_qp *ibqp, struct ib_pd *ibpd,
> > >
> > > /* IB ports start with 1, MANA Ethernet ports start with 0 */
> > > port = ucmd.port;
> > > - if (ucmd.port > mc->num_ports)
> > > + if (port < 1 || port > mc->num_ports)
> >
> > Why do I see port in mana_ib_create_qp? It should come from ib_qp_init_attr.
>
> I am so confused by this question. Are you asking me?
I asked *@microsoft folks.
> This is the _raw function.
_raw comes from QP type, it is not raw (basic) in a sense you imagine.
> I'm now sure what mana_ib_create_qp() has to do with it.
All create QP calls come through same verbs interface.
ib_create_qp_user->create_qp->.create_qp->mana_ib_create_qp->mana_ib_create_qp_raw
>
> The port comes from ib_copy_from_udata() which is just a wrapper around
> copy_from_user().
Right, and it shouldn't.
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2023-01-26 12:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 15:20 [PATCH] RDMA/mana_ib: Prevent array underflow in mana_ib_create_qp_raw() Dan Carpenter
2023-01-24 18:54 ` Long Li
2023-01-26 10:18 ` Leon Romanovsky
2023-01-26 11:00 ` Dan Carpenter
2023-01-26 12:18 ` Leon Romanovsky [this message]
2023-01-27 6:41 ` Long Li
2023-01-29 11:27 ` Leon Romanovsky
2023-02-02 8:39 ` Leon Romanovsky
2023-02-02 8:39 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9JvrfOezthLscEP@unreal \
--to=leon@kernel.org \
--cc=decui@microsoft.com \
--cc=error27@gmail.com \
--cc=jgg@ziepe.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=sharmaajay@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox