Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Dragos Tatulea <dtatulea@nvidia.com>, linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-rc v2] IB/IPoIB: Fix queue count for non-enhanced IPoIB over netlink
Date: Thu, 26 Jan 2023 14:40:56 -0400	[thread overview]
Message-ID: <Y9LJOHWYidVHBDMO@nvidia.com> (raw)
In-Reply-To: <Y9LH5kim0d5rBKOR@unreal>

On Thu, Jan 26, 2023 at 08:35:18PM +0200, Leon Romanovsky wrote:
> On Tue, Jan 24, 2023 at 08:24:18PM +0200, Leon Romanovsky wrote:
> > From: Dragos Tatulea <dtatulea@nvidia.com>
> > 
> > Make sure that non-enhanced IPoIB queues are configured with only
> > 1 tx and rx queues over netlink. This behavior is consistent with the
> > sysfs child_create configuration.
> > 
> > The cited commit opened up the possibility for child PKEY interface
> > to have multiple tx/rx queues. It is the driver's responsibility to
> > re-adjust the queue count accordingly. This patch does exactly that:
> > non-enhanced IPoIB supports only 1 tx and 1 rx queue.
> > 
> > Fixes: dbc94a0fb817 ("IB/IPoIB: Fix queue count inconsistency for PKEY child interfaces")
> > Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
> > Signed-off-by: Leon Romanovsky <leon@nvidia.coma
> > ---
> > Changelog:
> > v2:
> >  * Changed implementation
> > v1: https://lore.kernel.org/all/752143b0eef72a966662ce94526b1ceb5ba4bbb3.1674234106.git.leon@kernel.org
> >  * Fixed typo in warning print.
> > v0: https://lore.kernel.org/all/4a7ecec08ee30ad8004019818fadf1e58057e945.1674137153.git.leon@kernel.org>
> > ---
> >  drivers/infiniband/ulp/ipoib/ipoib_main.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> 
> 
> Dragos pointed to me that I sent commit with "old" commit message.
> The right one is below and I'll fix it locally once will apply it.
> 
> Jason, are you happy with the patch?

Why not use min?

Jason

  reply	other threads:[~2023-01-26 18:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24 18:24 [PATCH rdma-rc v2] IB/IPoIB: Fix queue count for non-enhanced IPoIB over netlink Leon Romanovsky
2023-01-26 18:35 ` Leon Romanovsky
2023-01-26 18:40   ` Jason Gunthorpe [this message]
2023-01-26 18:53     ` Leon Romanovsky
2023-01-26 19:02       ` Dragos Tatulea
2023-01-26 19:04         ` Jason Gunthorpe
2023-01-26 19:19 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9LJOHWYidVHBDMO@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=dtatulea@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox