From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CE27C433E0 for ; Mon, 22 Feb 2021 13:02:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BAFE64E4B for ; Mon, 22 Feb 2021 13:02:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231765AbhBVNBj (ORCPT ); Mon, 22 Feb 2021 08:01:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:60860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231506AbhBVNAw (ORCPT ); Mon, 22 Feb 2021 08:00:52 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7892164E41; Mon, 22 Feb 2021 13:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613998807; bh=nDRWYHNsa+cFWunPd5wmVkyRdJdv5f0ZF3Zd9b2ZiAQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Znn+NKOUvzUMhpEVyufbit3bf6FGwxqJbKPBTGxAL6nl9a7mpVItNCIGRttnPSTUW 4fttNwWwU2aBoMz3TpOtU8q3ZdKnVQ0tkiL0tm5URp6I6DDsty32S8mPJ4LsS7rUtX eK2su4okB/j8z+Eiwwo6jX8cKUG4FX6O9SuoC/OYCl52PUdMICSavE9JU7Dn+1dvnA PakEe4vv9wE3CqnzEhjYT3/IBC0jI2kIPncncmS5uzNzKQ0kWjKz/bEJbkobLm0EEJ +XfkYlHQ98/lxiVa/QO0XLQ9yKIaorjIUIB/lBg09DTu/Pv4ZRLdBlGut6zgWcC3J/ A9ycPRRqzeQvQ== Date: Mon, 22 Feb 2021 15:00:03 +0200 From: Leon Romanovsky To: Zhu Yanjun Cc: Julian Braha , Doug Ledford , RDMA mailing list , LKML Subject: Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO Message-ID: References: <21525878.NYvzQUHefP@ubuntu-mate-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Feb 22, 2021 at 10:39:20AM +0800, Zhu Yanjun wrote: > On Sun, Feb 21, 2021 at 2:49 PM Leon Romanovsky wrote: > > > > On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote: > > > commit 6e61907779ba99af785f5b2397a84077c289888a > > > Author: Julian Braha > > > Date: Fri Feb 19 18:20:57 2021 -0500 > > > > > > drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO > > > > > > When RDMA_RXE is enabled and CRYPTO is disabled, > > > Kbuild gives the following warning: > > > > > > WARNING: unmet direct dependencies detected for CRYPTO_CRC32 > > > Depends on [n]: CRYPTO [=n] > > > Selected by [y]: > > > - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && INFINIBAND_VIRT_DMA [=y] > > > > > > This is because RDMA_RXE selects CRYPTO_CRC32, > > > without depending on or selecting CRYPTO, despite that config option > > > being subordinate to CRYPTO. > > > > > > Signed-off-by: Julian Braha > > > > Please use git sent-email to send patches and please fix crypto Kconfig > > to enable CRYPTO if CRYPTO_* selected. > > > > It is a little bit awkward to request all users of CRYPTO_* to request > > select CRYPTO too. > > The same issue and similar patch is in this link: > > https://patchwork.kernel.org/project/linux-rdma/patch/20200915101559.33292-1-fazilyildiran@gmail.com/#23615747 So what prevents us from fixing CRYPTO Kconfig? Thanks > > Zhu Yanjun > > > > > Thanks > > > > > > > > diff --git a/drivers/infiniband/sw/rxe/Kconfig b/drivers/infiniband/sw/rxe/Kconfig > > > index 452149066792..06b8dc5093f7 100644 > > > --- a/drivers/infiniband/sw/rxe/Kconfig > > > +++ b/drivers/infiniband/sw/rxe/Kconfig > > > @@ -4,6 +4,7 @@ config RDMA_RXE > > > depends on INET && PCI && INFINIBAND > > > depends on INFINIBAND_VIRT_DMA > > > select NET_UDP_TUNNEL > > > + select CRYPTO > > > select CRYPTO_CRC32 > > > help > > > This driver implements the InfiniBand RDMA transport over > > > > > > > > >