From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00768C433DB for ; Wed, 24 Feb 2021 10:05:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A68C864E09 for ; Wed, 24 Feb 2021 10:05:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234738AbhBXKF0 (ORCPT ); Wed, 24 Feb 2021 05:05:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:50256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234636AbhBXKFD (ORCPT ); Wed, 24 Feb 2021 05:05:03 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3A05964ED3; Wed, 24 Feb 2021 10:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614161062; bh=Nw0mgdgis9xCN8z4FpRfRyO/GxKvWT8srH/JZMirdj4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UmsFkDeA6uKkNj+XRC8h6nMYId32B2FEl/B8EpyS1jCmqT0XZ3UV7jyKlBsnJn0sm 0mrSUZ8/UUx7GYJgMGK0Fa3Gz/yIcc5SeGGaeW4Ai0SdhlhGi7eOWCwO3xBOPlJeOR sJL3/wWp/RYHVETdcBu0/v/2WjRfO6q7xC7lbC3xxnKM2VI5oDiy+V4AabTj0vGyWi Ipfsxd4cMAeBm38zV9qAtkAxLxWeGuOKyjAu6N0dYvpw7OMX8c05FD1Tv/VAQS1bgP CiaJdJDj/kgA2m4aoomFFBsxegRFvVXHV9XqGz9GhkgsscvjMgpBTbB1arO0dvMGLk M2kyZ+eqtF7Ow== Date: Wed, 24 Feb 2021 12:04:19 +0200 From: Leon Romanovsky To: Arnd Bergmann Cc: Julian Braha , Randy Dunlap , Jason Gunthorpe , Arnd Bergmann , Zhu Yanjun , Doug Ledford , RDMA mailing list , LKML Subject: Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO Message-ID: References: <21525878.NYvzQUHefP@ubuntu-mate-laptop> <10464303.FBcTZR2von@ubuntu-mate-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Feb 23, 2021 at 11:05:45PM +0100, Arnd Bergmann wrote: > On Tue, Feb 23, 2021 at 10:54 PM Julian Braha wrote: > > On Tuesday, February 23, 2021 4:26:44 PM EST Arnd Bergmann wrote: > > > On Tue, Feb 23, 2021 at 9:46 PM Julian Braha wrote: > > > > > > > > I have other similar patches that I intend to submit. What should I do, > > > > going forward? Should I use "depends on CRYPTO" for cases like these? > > > > Should I resubmit this patch with that change? > > > > > > No, we should not mix the two methods, that just leads to circular dependencies. > > > > > > How many more patches do you have that need to get merged? > > > > > > If it's only a few, I'd suggest merging them first before we consider a > > > broader change. If the problem is very common, we may want to > > > think about alternative approaches first, and then change everything > > > at once. > > > > Sorry, I don't have a specific number, but it's certainly under a dozen patches. > > It's probably best to continue pushing those first then. Arnd, I'm hearing it over and over for a long time already. People are focused on micro-solutions instead of one, powerful change, which is not hard to do. Thanks > > Arnd