From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D3CFC433E0 for ; Sun, 28 Feb 2021 09:24:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0467864E4A for ; Sun, 28 Feb 2021 09:24:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230402AbhB1JYi (ORCPT ); Sun, 28 Feb 2021 04:24:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:43786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230075AbhB1JYh (ORCPT ); Sun, 28 Feb 2021 04:24:37 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8487164D99; Sun, 28 Feb 2021 09:23:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614504237; bh=K2JDpc7EhaBDnGCa1SHO84oOEesXXBSaulPWIzAy32Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=avk8JKXPReInenU8MsphKfb8fwcr61zbYEPnIifC5I27QqXu61i7iemgNsZGtY0yH T0Js6Ea82R0MdFz6oj7RMwMwMGIm+lAWpgdvAwsNdi3pHO53PgTN1B7fFJM5KqP27G sExuLnNcjX9C7pEEbVE7rhT1eM4TIlRktFUtUTlbq0FttkI74+USSa32h48nYiJpUA W90hu1PCg/riUkBhS1XTUA9eWkqvJDjB71rsmsBgM2PN6yohTLY+BLoEenVUu5aY/K bFGLNoFZWby25xB5AGE145xIcEkK2SZNdIAhNKlhxizZmE01+9gamIhDWTQvUCnbQ4 2s7++fnnw9zmQ== Date: Sun, 28 Feb 2021 11:23:53 +0200 From: Leon Romanovsky To: Zhu Yanjun Cc: Yi Zhang , RDMA mailing list Subject: Re: modprobe rdma_rxe failed when ipv6 disabled Message-ID: References: <1688338252.14107275.1614354083739.JavaMail.zimbra@redhat.com> <1010828157.14107334.1614354448762.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Sat, Feb 27, 2021 at 11:32:35PM +0800, Zhu Yanjun wrote: > From 9dcdd09f3ca3cf222b563866acd91d18bc4b93d4 Mon Sep 17 00:00:00 2001 > From: Zhu Yanjun > Date: Sat, 27 Feb 2021 23:01:15 +0000 > Subject: [PATCH 1/1] RDMA/rxe: Disable ipv6 features when ipv6.disable set in > cmdline > > When ipv6.disable=1 is set in cmdline, ipv6 is actually disabled > in the stack. As such, the operations of ipv6 in RXE will fail. > So ipv6 features in RXE should also be disabled in RXE. > > Reported-by: Yi Zhang > Signed-off-by: Zhu Yanjun > --- > drivers/infiniband/sw/rxe/rxe_net.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/infiniband/sw/rxe/rxe_net.c > b/drivers/infiniband/sw/rxe/rxe_net.c > index 0701bd1ffd1a..6ef092cb575e 100644 > --- a/drivers/infiniband/sw/rxe/rxe_net.c > +++ b/drivers/infiniband/sw/rxe/rxe_net.c > @@ -72,6 +72,11 @@ static struct dst_entry *rxe_find_route6(struct > net_device *ndev, > struct dst_entry *ndst; > struct flowi6 fl6 = { { 0 } }; > > + if (!ipv6_mod_enabled()) { > + pr_info("IPv6 is disabled by ipv6.disable=1 in cmdline"); > + return NULL; > + } > + Except the info message, the change looks valid. pr_info("IPv6 is disabled by ipv6.disable=1 in cmdline"); -> pr_info("IPv6 is disabled"); Thanks, Reviewed-by: Leon Romanovsky