From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2627C433ED for ; Sun, 4 Apr 2021 13:15:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6197D6134F for ; Sun, 4 Apr 2021 13:15:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229902AbhDDNPo (ORCPT ); Sun, 4 Apr 2021 09:15:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:36582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbhDDNPn (ORCPT ); Sun, 4 Apr 2021 09:15:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A63DD61210; Sun, 4 Apr 2021 13:15:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617542139; bh=F5BU3c8ulrHcngMnkVKeevAYqz8+ly+plYwNP3IB6/o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A95bpsJLF1e1zeYJritmas9caa2EDZ7d05RQ62dppYaJzCri14JpYc+j9Yri/VXgF 2km8HtKKbQa1D12E4IeAnCcNenUoqC3vsYwiuZ3oppJR8IJBfZQJb41eMpDikQizeH CWPlZTN5fRrT/lCt7ewOV1eGnze5vaqocLgMDCvcW/LRhOsG2jDLQNPQ+eAwmStj7M jyo9oiycs1SwbWLPxVEXi5ZFWWvaaKr4TVGCVotQsRaTMcVr1vCqtgCC4L3xfm3LDS A+q9FssaN9GLk5GTukkAuckzpdOq+WETXuG/c/UkqEaGFcuvtAo6PpcZSI/4P51Lni 3B04ALmRsUjvw== Date: Sun, 4 Apr 2021 16:15:35 +0300 From: Leon Romanovsky To: Mark Bloch Cc: Dan Carpenter , Doug Ledford , Jason Gunthorpe , Mark Bloch , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] RDMA/addr: potential uninitialized variable in ib_nl_process_good_ip_rsep() Message-ID: References: <1b21be94-bf14-9e73-68a3-c503bb79f683@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b21be94-bf14-9e73-68a3-c503bb79f683@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Sun, Apr 04, 2021 at 04:13:17PM +0300, Mark Bloch wrote: > On 4/4/21 1:33 PM, Leon Romanovsky wrote: > > On Fri, Apr 02, 2021 at 02:47:23PM +0300, Dan Carpenter wrote: > >> The nla_len() is less than or equal to 16. If it's less than 16 then > >> end of the "gid" buffer is uninitialized. > >> > >> Fixes: ae43f8286730 ("IB/core: Add IP to GID netlink offload") > >> Signed-off-by: Dan Carpenter > >> --- > >> I just spotted this in review. I think it's a bug but I'm not 100%. > > > > I tend to agree with you, that it is a bug. > > > > LS_NLA_TYPE_DGID is declared as NLA_BINARY which doesn't complain if > > data is less than declared ".len". However, the fix needs to be in > > ib_nl_is_good_ip_resp(), it shouldn't return "true" if length not equal > > to 16. > > What about just updating the policy? The bellow diff should work I believe. I didn't know about ".validation_type", but yes this change will be enough. > > diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c > index 0abce004a959..65e3e7df8a4b 100644 > --- a/drivers/infiniband/core/addr.c > +++ b/drivers/infiniband/core/addr.c > @@ -76,7 +76,9 @@ static struct workqueue_struct *addr_wq; > > static const struct nla_policy ib_nl_addr_policy[LS_NLA_TYPE_MAX] = { > [LS_NLA_TYPE_DGID] = {.type = NLA_BINARY, > - .len = sizeof(struct rdma_nla_ls_gid)}, > + .len = sizeof(struct rdma_nla_ls_gid), > + .validation_type = NLA_VALIDATE_MIN, > + .min = sizeof(struct rdma_nla_ls_gid)}, > }; > > static inline bool ib_nl_is_good_ip_resp(const struct nlmsghdr *nlh) > > > > > Thanks > > > > Mark