From: Leon Romanovsky <leon@kernel.org>
To: Praveen Kumar Kannoju <praveen.kannoju@oracle.com>
Cc: dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org,
rajesh.sivaramasubramaniom@oracle.com,
rama.nichanamatlu@oracle.com, aruna.ramakrishna@oracle.com,
jeffery.yoder@oracle.com
Subject: Re: [PATCH v3] IB/mlx5: Reduce max order of memory allocated for xlt update
Date: Sun, 4 Apr 2021 13:37:55 +0300 [thread overview]
Message-ID: <YGmXAyANXwRGosIe@unreal> (raw)
In-Reply-To: <1617425635-35631-1-git-send-email-praveen.kannoju@oracle.com>
On Sat, Apr 03, 2021 at 04:53:55AM +0000, Praveen Kumar Kannoju wrote:
> To update xlt (during mlx5_ib_reg_user_mr()), the driver can request up to
> 1 MB (order-8) memory, depending on the size of the MR. This costly
> allocation can sometimes take very long to return (a few seconds). This
> causes the calling application to hang for a long time, especially when the
> system is fragmented. To avoid these long latency spikes, the calls the
> higher order allocations need to fail faster in case they are not
> available. In order to acheive this we need __GFP_NORETRY flag in the
> gfp_mask before during fetching the free pages. This patch adds this flag
> to the mask.
>
> Signed-off-by: Praveen Kumar Kannoju <praveen.kannoju@oracle.com>
> ---
> drivers/infiniband/hw/mlx5/mr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks a lot,
Acked-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2021-04-04 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 4:53 [PATCH v3] IB/mlx5: Reduce max order of memory allocated for xlt update Praveen Kumar Kannoju
2021-04-04 10:37 ` Leon Romanovsky [this message]
2021-04-07 23:31 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGmXAyANXwRGosIe@unreal \
--to=leon@kernel.org \
--cc=aruna.ramakrishna@oracle.com \
--cc=dledford@redhat.com \
--cc=jeffery.yoder@oracle.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=praveen.kannoju@oracle.com \
--cc=rajesh.sivaramasubramaniom@oracle.com \
--cc=rama.nichanamatlu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox