From: Leon Romanovsky <leon@kernel.org>
To: Weihang Li <liweihang@huawei.com>
Cc: dledford@redhat.com, jgg@nvidia.com, linux-rdma@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH for-next 4/6] RDMA/core: Remove redundant spaces
Date: Tue, 6 Apr 2021 11:43:43 +0300 [thread overview]
Message-ID: <YGwfP0qEDMybR4iZ@unreal> (raw)
In-Reply-To: <1617697184-48683-5-git-send-email-liweihang@huawei.com>
On Tue, Apr 06, 2021 at 04:19:42PM +0800, Weihang Li wrote:
> From: Wenpeng Liang <liangwenpeng@huawei.com>
>
> Space is not required between function name and '(', after '(', before ')',
> before ',' and between '*' and symbol name of a definition.
>
> Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
> Signed-off-by: Weihang Li <liweihang@huawei.com>
> ---
> drivers/infiniband/core/cache.c | 10 +++---
> drivers/infiniband/core/cm.c | 31 ++++++++---------
> drivers/infiniband/core/cma.c | 10 +++---
> drivers/infiniband/core/device.c | 64 +++++++++++++++++------------------
> drivers/infiniband/core/mad.c | 20 +++++------
> drivers/infiniband/core/mad_rmpp.c | 10 +++---
> drivers/infiniband/core/nldev.c | 2 +-
> drivers/infiniband/core/security.c | 12 +++----
> drivers/infiniband/core/sysfs.c | 8 ++---
> drivers/infiniband/core/user_mad.c | 6 ++--
> drivers/infiniband/core/uverbs_cmd.c | 20 +++++------
> drivers/infiniband/core/uverbs_main.c | 3 +-
> drivers/infiniband/core/uverbs_uapi.c | 16 ++++-----
> 13 files changed, 105 insertions(+), 107 deletions(-)
>
> diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
> index d779590..0b8c410 100644
> --- a/drivers/infiniband/core/cache.c
> +++ b/drivers/infiniband/core/cache.c
> @@ -886,7 +886,7 @@ static void gid_table_release_one(struct ib_device *ib_dev)
> {
> u32 p;
>
> - rdma_for_each_port (ib_dev, p) {
> + rdma_for_each_port(ib_dev, p) {
This space is an outcome of clang formatter. I would say that we are
fine that submitted patches will be with and without space.
Thanks
next prev parent reply other threads:[~2021-04-06 8:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 8:19 [PATCH for-next 0/6] RDMA/core: Correct some coding-style issues Weihang Li
2021-04-06 8:19 ` [PATCH for-next 1/6] RDMA/core: Print the function name by __func__ instead of an fixed string Weihang Li
2021-04-06 8:19 ` [PATCH for-next 2/6] RDMA/core: Remove the redundant return statements Weihang Li
2021-04-06 8:19 ` [PATCH for-next 3/6] RDMA/core: Add necessary spaces Weihang Li
2021-04-06 8:41 ` Leon Romanovsky
2021-04-06 11:56 ` liweihang
2021-04-06 8:19 ` [PATCH for-next 4/6] RDMA/core: Remove redundant spaces Weihang Li
2021-04-06 8:43 ` Leon Romanovsky [this message]
2021-04-06 12:19 ` liweihang
2021-04-06 8:19 ` [PATCH for-next 5/6] RDMA/core: Correct format of braces Weihang Li
2021-04-06 8:19 ` [PATCH for-next 6/6] RDMA/core: Correct format of block comments Weihang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGwfP0qEDMybR4iZ@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liweihang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox