From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE3BDC433B4 for ; Tue, 6 Apr 2021 08:45:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DF6B613C3 for ; Tue, 6 Apr 2021 08:45:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244491AbhDFIpm (ORCPT ); Tue, 6 Apr 2021 04:45:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:43466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244485AbhDFIpl (ORCPT ); Tue, 6 Apr 2021 04:45:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 31BA2613C2; Tue, 6 Apr 2021 08:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617698733; bh=P4WkmhP18w3/qefzSYLBVb6xExN/hOqmzTYO9VJh9X8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rY+NtmgnsmhSAm+sGz8PgQxusLwGrHW7tXbTjq3PT2kkyVz7bKsRTsxQsGrBw6XZ7 HHSh2gc7E/9eqOPpO3hTS4Y1bqNrZcSqplpmK9X6Px+/kLAFr7riiQU2pBX1WlFkrh i+NiCnOf1YDofxkkftoUt2dTEwD8ZEN8WBkLhtL/eyhsGf4U0JUHN9HbiPK/PIl47h Om4aZ80KdiEr490QWsAxnXsjnChnnMQ/EtBCkUkaNqufqDoomSq8ya91xYvoCBujbi 0pkP3K4scUlstxTrh1IwHRdvq3Kj7VTVo02wArnwBh+WGk5wQVsdRhqHtJ+SVug8KM 1BO0rIUSdETeQ== Date: Tue, 6 Apr 2021 11:45:30 +0300 From: Leon Romanovsky To: Weihang Li Cc: dledford@redhat.com, jgg@nvidia.com, linux-rdma@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH for-next] RDMA/core: Flush workqueue before destroy it Message-ID: References: <1617698091-47439-1-git-send-email-liweihang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1617698091-47439-1-git-send-email-liweihang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Apr 06, 2021 at 04:34:51PM +0800, Weihang Li wrote: > From: Yixian Liu > > It is safer to flush the workqueue before destroying it. Sorry, safer for what? destroy_workqueue() flushes workqueue internally. There is no need to do it twice. Thanks > > Signed-off-by: Yixian Liu > Signed-off-by: Weihang Li > --- > drivers/infiniband/core/addr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c > index 0abce00..e58a06b 100644 > --- a/drivers/infiniband/core/addr.c > +++ b/drivers/infiniband/core/addr.c > @@ -883,6 +883,7 @@ int addr_init(void) > void addr_cleanup(void) > { > unregister_netevent_notifier(&nb); > + flush_workqueue(addr_wq); > destroy_workqueue(addr_wq); > WARN_ON(!list_empty(&req_list)); > } > -- > 2.8.1 >