From: Potnuri Bharat Teja <bharat@chelsio.com>
To: "jgg@nvidia.com" <jgg@nvidia.com>,
"dledford@redhat.com" <dledford@redhat.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH for-rc] RDMA/cxgb4: check for ipv6 address properly while destroying listener
Date: Tue, 6 Apr 2021 23:44:30 +0530 [thread overview]
Message-ID: <YGylBjulSvR1TEfx@chelsio.com> (raw)
In-Reply-To: <20210331135715.30072-1-bharat@chelsio.com>
On Wednesday, March 03/31/21, 2021 at 19:27:15 +0530, Potnuri Bharat Teja wrote:
> ipv6 bit is wrongly set by commit '3408be145a5d' which causes fatal adapter
> lookup engine errors for ipv4 connections while destroying listener.
> Current patch properly checks the local address for ipv6 and fixes the
> blunder introduced by commit '3408be145a5d'.
>
> Fixes: 3408be145a5d ("RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server")
> Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
Gentle reminder.
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index 81903749d241..e42c812e74c3 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -3616,7 +3616,8 @@ int c4iw_destroy_listen(struct iw_cm_id *cm_id)
> c4iw_init_wr_wait(ep->com.wr_waitp);
> err = cxgb4_remove_server(
> ep->com.dev->rdev.lldi.ports[0], ep->stid,
> - ep->com.dev->rdev.lldi.rxq_ids[0], true);
> + ep->com.dev->rdev.lldi.rxq_ids[0],
> + ep->com.local_addr.ss_family == AF_INET6);
> if (err)
> goto done;
> err = c4iw_wait_for_reply(&ep->com.dev->rdev, ep->com.wr_waitp,
> --
> 2.24.0
>
next prev parent reply other threads:[~2021-04-06 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 13:57 [PATCH for-rc] RDMA/cxgb4: check for ipv6 address properly while destroying listener Potnuri Bharat Teja
2021-04-06 18:14 ` Potnuri Bharat Teja [this message]
2021-04-07 23:04 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGylBjulSvR1TEfx@chelsio.com \
--to=bharat@chelsio.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox