From: Leon Romanovsky <leonro@nvidia.com>
To: Gioh Kim <gi-oh.kim@ionos.com>
Cc: <linux-block@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<axboe@kernel.dk>, <akinobu.mita@gmail.com>, <corbet@lwn.net>,
<hch@infradead.org>, <sagi@grimberg.me>, <bvanassche@acm.org>,
<haris.iqbal@ionos.com>, <jinpu.wang@ionos.com>,
Gioh Kim <gi-oh.kim@cloud.ionos.com>,
<linux-rdma@vger.kernel.org>,
Guoqing Jiang <guoqing.jiang@ionos.com>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCHv5 for-next 08/19] block/rnbd-clt: Replace {NO_WAIT,WAIT} with RTRS_PERMIT_{WAIT,NOWAIT}
Date: Mon, 19 Apr 2021 10:46:56 +0300 [thread overview]
Message-ID: <YH01cJefECbRDZLl@unreal> (raw)
In-Reply-To: <20210419073722.15351-9-gi-oh.kim@ionos.com>
On Mon, Apr 19, 2021 at 09:37:11AM +0200, Gioh Kim wrote:
> From: Gioh Kim <gi-oh.kim@cloud.ionos.com>
>
> They are defined with the same value and similar meaning, let's remove
> one of them, then we can remove {WAIT,NOWAIT}.
>
> Also change the type of 'wait' from 'int' to 'enum wait_type' to make
> it clear.
>
> Cc: Leon Romanovsky <leonro@nvidia.com>
> Cc: linux-rdma@vger.kernel.org
> Signed-off-by: Guoqing Jiang <guoqing.jiang@ionos.com>
> Reviewed-by: Md Haris Iqbal <haris.iqbal@ionos.com>
> Signed-off-by: Gioh Kim <gi-oh.kim@ionos.com>
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> Acked-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/block/rnbd/rnbd-clt.c | 42 +++++++++++---------------
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 4 +--
> drivers/infiniband/ulp/rtrs/rtrs.h | 6 ++--
> 3 files changed, 22 insertions(+), 30 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2021-04-19 7:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210419073722.15351-1-gi-oh.kim@ionos.com>
2021-04-19 7:37 ` [PATCHv5 for-next 08/19] block/rnbd-clt: Replace {NO_WAIT,WAIT} with RTRS_PERMIT_{WAIT,NOWAIT} Gioh Kim
2021-04-19 7:46 ` Leon Romanovsky [this message]
2021-04-19 7:37 ` [PATCHv5 for-next 13/19] block/rnbd-clt: Support polling mode for IO latency optimization Gioh Kim
2021-04-19 7:47 ` Leon Romanovsky
2021-04-19 7:37 ` [PATCHv5 for-next 15/19] block/rnbd-srv: Remove unused arguments of rnbd_srv_rdma_ev Gioh Kim
2021-04-19 7:47 ` Leon Romanovsky
2021-04-19 7:37 ` [PATCHv5 for-next 17/19] block/rnbd-clt: Remove max_segment_size Gioh Kim
2021-04-19 7:47 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH01cJefECbRDZLl@unreal \
--to=leonro@nvidia.com \
--cc=akinobu.mita@gmail.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=corbet@lwn.net \
--cc=gi-oh.kim@cloud.ionos.com \
--cc=gi-oh.kim@ionos.com \
--cc=guoqing.jiang@ionos.com \
--cc=haris.iqbal@ionos.com \
--cc=hch@infradead.org \
--cc=jgg@nvidia.com \
--cc=jinpu.wang@ionos.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox