From: Leon Romanovsky <leon@kernel.org>
To: "Saleem, Shiraz" <shiraz.saleem@intel.com>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH rdma-rc v1] RDMA/core: Sanitize WQ state received from the userspace
Date: Wed, 19 May 2021 08:27:34 +0300 [thread overview]
Message-ID: <YKShxoNM9Az8GQ0q@unreal> (raw)
In-Reply-To: <b40b9bac4f3e4a628bee17b5b5acc61a@intel.com>
On Tue, May 18, 2021 at 10:07:38PM +0000, Saleem, Shiraz wrote:
> > Subject: [PATCH rdma-rc v1] RDMA/core: Sanitize WQ state received from the
> > userspace
> >
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > The mlx4 and mlx5 implemented differently the WQ input checks.
> > Instead of duplicating mlx4 logic in the mlx5, let's prepare the input in the central
> > place.
>
> Maybe some more verbiage about what the bug was in mlx5 that prompted this patch would
> be good since this an -rc fix.
It can go to -next too, the bug is that we didn't check for validity of
state input in mlx5. It is not real bug because our FW checked that, but
still worth to fix.
I'll add this.
Thanks
>
> Shiraz
prev parent reply other threads:[~2021-05-19 5:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 12:58 [PATCH rdma-rc v1] RDMA/core: Sanitize WQ state received from the userspace Leon Romanovsky
2021-05-18 22:07 ` Saleem, Shiraz
2021-05-19 5:27 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKShxoNM9Az8GQ0q@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox