From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9F49C43460 for ; Wed, 19 May 2021 05:39:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCFE5611BF for ; Wed, 19 May 2021 05:39:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242599AbhESFlL (ORCPT ); Wed, 19 May 2021 01:41:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:33458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344991AbhESFif (ORCPT ); Wed, 19 May 2021 01:38:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 17D50611BF; Wed, 19 May 2021 05:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621402636; bh=/wserOAM71RxcqsBZBi62Nr8Kzx6ii8wtkOB0XiIVZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N5fo9t0CXUmUiJ6RYESAXULd7nEiQ5eLOxPvVFYOnZeal59HtjtSXMIEengDMh1L0 Nq1JKywIDrrYO5kRl4RrrZLJY+OdvHcp7rI+cKHaRwwIyjoYzmCeX/GOGoVehQRDYO MQhABZi6ArVh1BtKOF4tTmrhFZx7pI3wyv4EeD9GLa8UnsFvajMiutnTs1VDYJuS5x ma/1YAqxjIFbVcmJEZcIw2uiVVvnXIThS8hp66AfXXTeKOgeLcwEw+WAyPVjvwSIt4 /YqeZ2jznzZFkMklLfK08aZvLE0uOmdPr40Z8Muro4h5qto8qFoRT9aNTyxlzGecc2 /rz5elMajzQTA== Date: Wed, 19 May 2021 08:37:12 +0300 From: Leon Romanovsky To: Dan Carpenter Cc: Doug Ledford , Jason Gunthorpe , Avihai Horon , Michael Guralnik , Aharon Landau , Gal Pressman , Yishai Hadas , Parav Pandit , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] RDMA/uverbs: fix a NULL vs IS_ERR() bug Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, May 14, 2021 at 05:18:10PM +0300, Dan Carpenter wrote: > The uapi_get_object() function returns error pointers, it never returns > NULL. > > Fixes: 149d3845f4a5 ("RDMA/uverbs: Add a method to introspect handles in a context") > Signed-off-by: Dan Carpenter > --- > drivers/infiniband/core/uverbs_std_types_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky