From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A24C433B4 for ; Wed, 19 May 2021 09:01:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1417B6112F for ; Wed, 19 May 2021 09:01:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344372AbhESJC5 (ORCPT ); Wed, 19 May 2021 05:02:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:37732 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232558AbhESJCz (ORCPT ); Wed, 19 May 2021 05:02:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B6D06610E9; Wed, 19 May 2021 09:01:35 +0000 (UTC) Date: Wed, 19 May 2021 12:01:33 +0300 From: Leon Romanovsky To: Bart Van Assche Cc: Jason Gunthorpe , Doug Ledford , linux-rdma@vger.kernel.org, Nicolas Morey-Chaisemartin Subject: Re: [PATCH 2/5] RDMA/srp: Add more structure size checks Message-ID: References: <20210512032752.16611-1-bvanassche@acm.org> <20210512032752.16611-3-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210512032752.16611-3-bvanassche@acm.org> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, May 11, 2021 at 08:27:49PM -0700, Bart Van Assche wrote: > Before modifying how the __packed attribute is used, add compile time > size checks for the structures that will be modified. > > Cc: Nicolas Morey-Chaisemartin > Signed-off-by: Bart Van Assche > --- > drivers/infiniband/ulp/srp/ib_srp.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky